From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Angel Iglesias" <ang.iglesiasg@gmail.com>,
linux-iio@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Nuno Sá" <noname.nuno@gmail.com>,
"Wolfram Sang" <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] i2c: core: Introduce i2c_client_get_device_id helper
Date: Sat, 5 Nov 2022 14:56:58 +0000 [thread overview]
Message-ID: <20221105145658.45b0e9da@jic23-huawei> (raw)
In-Reply-To: <Y2E0BWyvHjPko2TB@smile.fi.intel.com>
On Tue, 1 Nov 2022 16:58:13 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Sun, Oct 30, 2022 at 06:51:06PM +0100, Angel Iglesias wrote:
> > Hello,
> >
> > I don't want to step anyone's work here, so I'm sending this RFC to the
> > devs involved in the original discussion. I read on Uwe Kleine-König's
> > patchset submission thread the necessity for an i2c helper to aid with the
> > migration to the new i2c_driver .probe_new callback. Following the
> > suggestions made there, I wrote this small patchset implementing the
> > suggested helper function and ported the bmp280 IIO i2c probe to the new
> > probe using that helper.
>
> For the entire series (please drop RFC in the next version)
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I'm happy to pick up the next version but a question on 'route' in to the kernel.
I can do an immutable branch with just the new function call in it if
that is useful given I assume this is applicable across a bunch of subsystems?
Jonathan
>
> > Thanks for your time!
> > Angel
> >
> > Original discussion thread for additional context:
> > https://lore.kernel.org/all/20221023132302.911644-11-u.kleine-koenig@pengutronix.de/
> >
> > Angel Iglesias (2):
> > i2c: core: Introduce i2c_client_get_device_id helper function
> > iio: pressure: bmp280: convert to i2c's .probe_new()
> >
> > drivers/i2c/i2c-core-base.c | 15 +++++++++++++++
> > drivers/iio/pressure/bmp280-i2c.c | 8 ++++----
> > include/linux/i2c.h | 1 +
> > 3 files changed, 20 insertions(+), 4 deletions(-)
> >
> >
> > base-commit: c32793afc6976e170f6ab11ca3750fe94fb3454d
> > --
> > 2.38.1
> >
>
next prev parent reply other threads:[~2022-11-05 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 17:51 [RFC PATCH 0/2] i2c: core: Introduce i2c_client_get_device_id helper Angel Iglesias
2022-10-30 17:52 ` [RFC PATCH 1/2] i2c: core: Introduce i2c_client_get_device_id helper function Angel Iglesias
2022-11-01 13:09 ` Wolfram Sang
2022-11-01 14:54 ` Uwe Kleine-König
2022-11-01 23:53 ` Angel Iglesias
2022-10-30 17:53 ` [RFC PATCH 2/2] iio: pressure: bmp280: convert to i2c's .probe_new() Angel Iglesias
2022-11-01 21:52 ` Uwe Kleine-König
2022-11-02 0:16 ` Angel Iglesias
2022-11-05 14:54 ` Jonathan Cameron
2022-11-01 14:58 ` [RFC PATCH 0/2] i2c: core: Introduce i2c_client_get_device_id helper Andy Shevchenko
2022-11-05 14:56 ` Jonathan Cameron [this message]
2022-11-05 21:29 ` Wolfram Sang
2022-11-06 12:09 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221105145658.45b0e9da@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ang.iglesiasg@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox