From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42BA3C43217 for ; Sat, 5 Nov 2022 08:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229570AbiKEIwu (ORCPT ); Sat, 5 Nov 2022 04:52:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiKEIws (ORCPT ); Sat, 5 Nov 2022 04:52:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C63322528; Sat, 5 Nov 2022 01:52:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 48428B81647; Sat, 5 Nov 2022 08:52:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 714F0C433D6; Sat, 5 Nov 2022 08:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667638364; bh=ifUEBOIjQaHmKSCsfN+pCNH9FtC0PXujxXMPd3U2Z5s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZFK7Q0k5/PyWzAUtzXCwB/8pi6eFMlDppfJllc6PQHVruX4YQdFl8n3jRHPrF7Gih kOOMBl4WAyYako3HFAi9INuNy3ksMWbiSSw64aGskPAOyuwwt6jL/x7/G3SF6t3MRz nnMrgUEUUJUQZIbadctLQLLTGoA4HxxqYV33q99aUbb3O8opxaq/2r49PTm6olBjtS hKffbZA+xH4Tr0CyLTjLsq1XGupOKGaY3i+5PQ6RBDH+cpK9+n+OqaOaw4KXfNc2fS v1vur1WotNh2Bu879jcvKiqjje+MI57mT7F8za11dBx8mAplqbD72qnj47x7mtBv1p fpIz9RZcYWlwQ== Date: Sat, 5 Nov 2022 17:52:41 +0900 From: Masami Hiramatsu (Google) To: Yipeng Zou Cc: , , , , Subject: Re: [PATCH] selftests/ftrace: event_triggers: wait longer for test_event_enable Message-Id: <20221105175241.858bbd5b5337fc2b8a075ee9@kernel.org> In-Reply-To: <20221104020931.231090-1-zouyipeng@huawei.com> References: <20221104020931.231090-1-zouyipeng@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yipeng, On Fri, 4 Nov 2022 10:09:31 +0800 Yipeng Zou wrote: > In some platform, the schedule event may came slowly, delay 100ms can't > cover it. > > I was notice that on my board which running in low cpu_freq,and this > selftests allways gose fail. This looks good to me, since this can just extend the waiting time to 1 sec. (and most of the platforms have no effect) Acked-by: Masami Hiramatsu (Google) Thank you! > > So maybe we can check more times here to wait longer. > > Fixes: 43bb45da82f9 ("selftests: ftrace: Add a selftest to test event enable/disable func trigger") > Signed-off-by: Yipeng Zou > --- > .../ftrace/test.d/ftrace/func_event_triggers.tc | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > index 8d26d5505808..3eea2abf68f9 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc > @@ -38,11 +38,18 @@ cnt_trace() { > > test_event_enabled() { > val=$1 > + check_times=10 # wait for 10 * SLEEP_TIME at most > > - e=`cat $EVENT_ENABLE` > - if [ "$e" != $val ]; then > - fail "Expected $val but found $e" > - fi > + while [ $check_times -ne 0 ]; do > + e=`cat $EVENT_ENABLE` > + if [ "$e" == $val ]; then > + return 0 > + fi > + sleep $SLEEP_TIME > + check_times=$((check_times - 1)) > + done > + > + fail "Expected $val but found $e" > } > > run_enable_disable() { > -- > 2.17.1 > -- Masami Hiramatsu (Google)