From: Steven Rostedt <rostedt@goodmis.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers
Date: Sat, 5 Nov 2022 23:12:41 -0400 [thread overview]
Message-ID: <20221105231241.7513fc33@rorschach.local.home> (raw)
In-Reply-To: <b52c207c-e7bf-af2e-61d9-116c9e76af86@inria.fr>
On Sun, 6 Nov 2022 11:05:14 +0800 (+08)
Julia Lawall <julia.lawall@inria.fr> wrote:
> > Thinking that's what you meant (examples would be easier to understand,
> > than descriptions). And it didn't cover the return case. Does it only
> > cover gotos?
> >
> > See drivers/net/wireless/intel/iwlwifi/mvm/sta.c for the false positive case:
> >
> > del_timer_sync(&baid_data->session_timer);
> > [..]
>
> But there is a kfree_rcu(baid_data, rcu_head); right below. So it looks
> fine?
D'oh! I think you are correct. I didn't trust the script and it appears
that it was correct all along. The free was hidden in between the code
and I only noticed the kfree() in the error path. I thought that was a
bug in the script. :-/
I guess there were no false positives then. To be sure, I'll write a
script to find all that have a return or goto in between and see what
it comes up with.
I guess my original patch doesn't need any changes from the script.
I'll look more.
Thanks Julia!
-- Steve
next prev parent reply other threads:[~2022-11-06 3:13 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 6:00 [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 01/38] SUNRPC/xprt: Use del_timer_sync() instead of del_singleshot_timer_sync() Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 03/38] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function Steven Rostedt
2022-11-05 9:38 ` Marc Zyngier
2022-11-05 14:07 ` Guenter Roeck
2022-11-05 14:42 ` Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 04/38] clocksource/drivers/sp804: " Steven Rostedt
2022-11-05 14:06 ` Guenter Roeck
2022-11-05 6:00 ` [PATCH v4a 05/38] timers: Add timer_shutdown_sync() and timer_shutdown() to be called before freeing timers Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 06/38] timers: sh: Use timer_shutdown_sync() before freeing timer Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 08/38] timers: ACPI: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 09/38] timers: atm: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 10/38] timers: Bluetooth: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 12/38] timers: HID: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 14/38] timers: mISDN: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 15/38] timers: leds: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 17/38] timers: net: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 18/38] timers: usb: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 19/38] timers: nfc: pn533: " Steven Rostedt
2022-11-07 10:13 ` Krzysztof Kozlowski
2022-11-05 6:00 ` [PATCH v4a 20/38] timers: pcmcia: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 21/38] timers: scsi: Use timer_shutdown_sync() and timer_shutdown() " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 22/38] timers: tty: Use timer_shutdown_sync() " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 23/38] timers: ext4: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 24/38] timers: fs/nilfs2: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 25/38] timers: ALSA: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 26/38] timers: jbd2: Use timer_shutdown() " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 27/38] timers: sched/psi: Use timer_shutdown_sync() " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 28/38] timers: workqueue: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 29/38] random: use timer_shutdown_sync() for on stack timers Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 33/38] timers: s390/cmm: Use timer_shutdown_sync() before a module is released Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 34/38] timers: atm: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 35/38] timers: hangcheck: " Steven Rostedt
2022-11-05 6:01 ` [PATCH v4a 36/38] timers: ipmi: " Steven Rostedt
2022-11-05 6:01 ` [PATCH v4a 38/38] timers: PM: Use timer_shutdown_sync() Steven Rostedt
[not found] ` <20221105060200.540142479@goodmis.org>
2022-11-05 9:54 ` [PATCH v4a 31/38] timers: drm: Use timer_shutdown_sync() for on stack timers Noralf Trønnes
2022-11-05 14:18 ` [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers Guenter Roeck
2022-11-05 14:47 ` Steven Rostedt
2022-11-05 15:59 ` Linus Torvalds
2022-11-05 16:36 ` Steven Rostedt
2022-11-05 16:53 ` Steven Rostedt
2022-11-05 18:03 ` Steven Rostedt
2022-11-05 18:05 ` Steven Rostedt
2022-11-05 18:28 ` Linus Torvalds
2022-11-05 18:43 ` Steven Rostedt
2022-11-05 23:08 ` Julia Lawall
2022-11-06 0:36 ` Steven Rostedt
2022-11-06 2:38 ` Julia Lawall
2022-11-06 3:05 ` Julia Lawall
2022-11-06 3:12 ` Steven Rostedt [this message]
2022-11-06 3:15 ` Julia Lawall
2022-11-05 21:03 ` Jason A. Donenfeld
2022-11-05 21:13 ` Linus Torvalds
2022-11-05 21:45 ` Steven Rostedt
2022-11-05 21:47 ` Steven Rostedt
2022-11-05 17:53 ` Steven Rostedt
[not found] ` <20221105060155.228348078@goodmis.org>
2022-11-05 14:05 ` [PATCH v4a 02/38] ARM: spear: Do not use timer namespace for timer_shutdown() function Guenter Roeck
2022-11-07 5:46 ` Viresh Kumar
2022-11-05 18:12 ` Arnd Bergmann
2022-11-05 19:31 ` [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers Guenter Roeck
[not found] ` <20221105060200.357061890@goodmis.org>
2022-11-07 14:12 ` [PATCH v4a 30/38] timers: dma-buf: Use timer_shutdown_sync() for on stack timers Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221105231241.7513fc33@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox