From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA2EC4332F for ; Mon, 7 Nov 2022 05:56:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbiKGF4w (ORCPT ); Mon, 7 Nov 2022 00:56:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231177AbiKGF4u (ORCPT ); Mon, 7 Nov 2022 00:56:50 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8CA1BCBF; Sun, 6 Nov 2022 21:56:49 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 5615B68BFE; Mon, 7 Nov 2022 06:56:47 +0100 (CET) Date: Mon, 7 Nov 2022 06:56:47 +0100 From: Christoph Hellwig To: Yu Kuai Cc: hch@lst.de, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, yukuai3@huawei.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH v2 5/5] blk-iocost: read params inside lock in sysfs apis Message-ID: <20221107055647.GH28873@lst.de> References: <20221104023938.2346986-1-yukuai1@huaweicloud.com> <20221104023938.2346986-6-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221104023938.2346986-6-yukuai1@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig