public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: stable@vger.kernel.org, Wentong Wu <wentong.wu@intel.com>,
	Srikanth Thokala <srikanth.thokala@intel.com>,
	Aman Kumar <aman.kumar@intel.com>
Subject: [PATCH 3/4] serial: 8250_lpss: Use 16B DMA burst with Elkhart Lake
Date: Mon,  7 Nov 2022 13:07:07 +0200	[thread overview]
Message-ID: <20221107110708.58223-4-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20221107110708.58223-1-ilpo.jarvinen@linux.intel.com>

Configure DMA to use 16B burst size with Elkhart Lake. This makes the
bus use more efficient and works around an issue which occurs with the
previously used 1B.

Fixes: 0a9410b981e9 ("serial: 8250_lpss: Enable DMA on Intel Elkhart Lake")
Cc: <stable@vger.kernel.org> # serial: 8250_lpss: Configure DMA also w/o DMA filter
Reported-by: Wentong Wu <wentong.wu@intel.com>
Co-developed-by: Srikanth Thokala <srikanth.thokala@intel.com>
Signed-off-by: Srikanth Thokala <srikanth.thokala@intel.com>
Co-developed-by: Aman Kumar <aman.kumar@intel.com>
Signed-off-by: Aman Kumar <aman.kumar@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

---
I know the list of Co-dev-bys & Sob seems a bit odd for a oneliner.
The reason is that I cleaned up this from a more complex patch using
the earlier change that I authored myself so only this oneliner
remained in this patch.
---
 drivers/tty/serial/8250/8250_lpss.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
index ed281445a97d..e0b4e1446eac 100644
--- a/drivers/tty/serial/8250/8250_lpss.c
+++ b/drivers/tty/serial/8250/8250_lpss.c
@@ -174,6 +174,8 @@ static int ehl_serial_setup(struct lpss8250 *lpss, struct uart_port *port)
 	 */
 	up->dma = dma;
 
+	lpss->dma_maxburst = 16;
+
 	port->set_termios = dw8250_do_set_termios;
 
 	return 0;
-- 
2.30.2


  parent reply	other threads:[~2022-11-07 11:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07 11:07 [PATCH 0/4] 8250: DMA Fixes Ilpo Järvinen
2022-11-07 11:07 ` [PATCH 1/4] serial: 8250: Fall back to non-DMA Rx if IIR_RDI occurs Ilpo Järvinen
2022-11-07 11:07 ` [PATCH 2/4] serial: 8250_lpss: Configure DMA also w/o DMA filter Ilpo Järvinen
2022-11-07 11:36   ` Andy Shevchenko
2022-11-07 11:07 ` Ilpo Järvinen [this message]
2022-11-07 11:38   ` [PATCH 3/4] serial: 8250_lpss: Use 16B DMA burst with Elkhart Lake Andy Shevchenko
2022-11-07 11:07 ` [PATCH 4/4] serial: 8250: Flush DMA Rx on RLSI Ilpo Järvinen
2022-11-07 11:40   ` Andy Shevchenko
2022-11-07 11:32 ` [PATCH 0/4] 8250: DMA Fixes Andy Shevchenko
2022-11-07 11:50   ` Ilpo Järvinen
2022-11-07 12:03     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221107110708.58223-4-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=aman.kumar@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=srikanth.thokala@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=wentong.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox