From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
stable@vger.kernel.org, "Gilles BULOZ" <gilles.buloz@kontron.com>
Subject: [PATCH 4/4] serial: 8250: Flush DMA Rx on RLSI
Date: Mon, 7 Nov 2022 13:07:08 +0200 [thread overview]
Message-ID: <20221107110708.58223-5-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20221107110708.58223-1-ilpo.jarvinen@linux.intel.com>
Returning true from handle_rx_dma() without flushing DMA first creates
a data ordering hazard. If DMA Rx has handled any character at the
point when RLSI occurs, the non-DMA path handles any pending characters
jumping them ahead of those characters that are pending under DMA.
Fixes: 75df022b5f89 ("serial: 8250_dma: Fix RX handling")
Cc: <stable@vger.kernel.org>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
Cc: Gilles BULOZ <gilles.buloz@kontron.com>
drivers/tty/serial/8250/8250_port.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 92dd18716169..388172289627 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -1901,10 +1901,9 @@ static bool handle_rx_dma(struct uart_8250_port *up, unsigned int iir)
if (!up->dma->rx_running)
break;
fallthrough;
+ case UART_IIR_RLSI:
case UART_IIR_RX_TIMEOUT:
serial8250_rx_dma_flush(up);
- fallthrough;
- case UART_IIR_RLSI:
return true;
}
return up->dma->rx_dma(up);
--
2.30.2
next prev parent reply other threads:[~2022-11-07 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 11:07 [PATCH 0/4] 8250: DMA Fixes Ilpo Järvinen
2022-11-07 11:07 ` [PATCH 1/4] serial: 8250: Fall back to non-DMA Rx if IIR_RDI occurs Ilpo Järvinen
2022-11-07 11:07 ` [PATCH 2/4] serial: 8250_lpss: Configure DMA also w/o DMA filter Ilpo Järvinen
2022-11-07 11:36 ` Andy Shevchenko
2022-11-07 11:07 ` [PATCH 3/4] serial: 8250_lpss: Use 16B DMA burst with Elkhart Lake Ilpo Järvinen
2022-11-07 11:38 ` Andy Shevchenko
2022-11-07 11:07 ` Ilpo Järvinen [this message]
2022-11-07 11:40 ` [PATCH 4/4] serial: 8250: Flush DMA Rx on RLSI Andy Shevchenko
2022-11-07 11:32 ` [PATCH 0/4] 8250: DMA Fixes Andy Shevchenko
2022-11-07 11:50 ` Ilpo Järvinen
2022-11-07 12:03 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107110708.58223-5-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gilles.buloz@kontron.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox