RE: [Patch v10 01/12] net: mana: Add support for auxiliary device

Long Li
2022-11-08T21:33:31Z

> > int mana_probe(struct gdma_dev *gd, bool resuming)
> > break;
> > }
> > }
> > +
> > + err = add_adev(gd);
> > out:
> > if (err)
> > mana_remove(gd, false);
> > @@ -2189,6 +2267,10 @@ void mana_remove(struct gdma_dev *gd, bool
> suspending)
> > int err;
> > int i;
> >
> > + /* adev currently doesn't support suspending, always remove it */
> > + if (gd->adev)
>
> This condition is always true, isn't it?

I think the check is necessary. mana_probe() will call mana_remove() if it fails to
add this adev to gd. If this is the case, we can't call remove_adev().

Thanks,
Long