public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Osama Muhammad <osmtendev@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
	Osama Muhammad <osmtendev@gmail.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: [PATCH 10/15] Accessiblity: speakup_keypc: specifying the default driver parameters among the module params
Date: Thu, 10 Nov 2022 02:51:03 +0500	[thread overview]
Message-ID: <20221109215108.7933-11-osmtendev@gmail.com> (raw)
In-Reply-To: <20221109215108.7933-1-osmtendev@gmail.com>

This is an enhancement which allows to specify the default driver
parameters among the module parameters.

Adding default variables to the speakup_keypc module
allows to easily set that at boot, rather than
setting the sys variables after boot.
More details can be found here:
https://github.com/linux-speakup/speakup/issues/7

Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 drivers/accessibility/speakup/speakup_keypc.c | 29 +++++++++++++++----
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/drivers/accessibility/speakup/speakup_keypc.c b/drivers/accessibility/speakup/speakup_keypc.c
index f61b62f1ea4d..9356f6379560 100644
--- a/drivers/accessibility/speakup/speakup_keypc.c
+++ b/drivers/accessibility/speakup/speakup_keypc.c
@@ -33,12 +33,21 @@ static int synth_port;
 static int port_forced;
 static unsigned int synth_portlist[] = { 0x2a8, 0 };
 
-static struct var_t vars[] = {
-	{ CAPS_START, .u.s = {"[f130]" } },
-	{ CAPS_STOP, .u.s = {"[f90]" } },
-	{ RATE, .u.n = {"\04%c ", 8, 0, 10, 81, -8, NULL } },
-	{ PITCH, .u.n = {"[f%d]", 5, 0, 9, 40, 10, NULL } },
-	{ DIRECT, .u.n = {NULL, 0, 0, 1, 0, 0, NULL } },
+
+enum default_vars_id {
+	CAPS_START_ID = 0, CAPS_STOP_ID,
+	RATE_ID, PITCH_ID,
+	DIRECT_ID, V_LAST_VAR_ID,
+	NB_ID
+};
+
+
+static struct var_t vars[NB_ID] = {
+	[CAPS_START_ID] = { CAPS_START, .u.s = {"[f130]" } },
+	[CAPS_STOP_ID] = { CAPS_STOP, .u.s = {"[f90]" } },
+	[RATE_ID] = { RATE, .u.n = {"\04%c ", 8, 0, 10, 81, -8, NULL } },
+	[PITCH_ID] = { PITCH, .u.n = {"[f%d]", 5, 0, 9, 40, 10, NULL } },
+	[DIRECT_ID] = { DIRECT, .u.n = {NULL, 0, 0, 1, 0, 0, NULL } },
 	V_LAST_VAR
 };
 
@@ -305,9 +314,17 @@ static void keynote_release(struct spk_synth *synth)
 
 module_param_hw_named(port, port_forced, int, ioport, 0444);
 module_param_named(start, synth_keypc.startup, short, 0444);
+module_param_named(rate, vars[RATE_ID].u.n.default_val, int, 0444);
+module_param_named(pitch, vars[PITCH_ID].u.n.default_val, int, 0444);
+module_param_named(direct, vars[DIRECT_ID].u.n.default_val, int, 0444);
 
 MODULE_PARM_DESC(port, "Set the port for the synthesizer (override probing).");
 MODULE_PARM_DESC(start, "Start the synthesizer once it is loaded.");
+MODULE_PARM_DESC(rate, "Set the rate variable on load.");
+MODULE_PARM_DESC(pitch, "Set the pitch variable on load.");
+MODULE_PARM_DESC(direct, "Set the direct variable on load.");
+
+
 
 module_spk_synth(synth_keypc);
 
-- 
2.25.1


  parent reply	other threads:[~2022-11-09 21:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 21:50 [PATCH 00/15] Accessiblity: speakup: specifying the default driver parameters among the module params Osama Muhammad
2022-11-09 21:50 ` [PATCH 01/15] Accessiblity: speakup_soft: " Osama Muhammad
2022-11-09 21:50 ` [PATCH 02/15] Accessiblity: speakup_apollo: " Osama Muhammad
2022-11-09 21:50 ` [PATCH 03/15] Accessiblity: speakup_audptr: " Osama Muhammad
2022-11-09 21:50 ` [PATCH 04/15] Accessiblity: speakup_bns: " Osama Muhammad
2022-11-09 21:50 ` [PATCH 05/15] Accessiblity: speakup_decext: " Osama Muhammad
2022-11-09 21:50 ` [PATCH 06/15] Accessiblity: speakup_decpc: " Osama Muhammad
2022-11-09 21:51 ` [PATCH 07/15] Accessiblity: speakup_dectlk: " Osama Muhammad
2022-11-09 21:51 ` [PATCH 08/15] Accessiblity: speakup_dtlk: " Osama Muhammad
2022-11-09 21:51 ` [PATCH 09/15] Accessiblity: speakup_dummy: " Osama Muhammad
2022-11-09 21:51 ` Osama Muhammad [this message]
2022-11-09 21:51 ` [PATCH 11/15] Accessiblity: speakup_ltlk: " Osama Muhammad
2022-11-09 21:51 ` [PATCH 12/15] Accessiblity: speakup_spkout: " Osama Muhammad
2022-11-09 21:51 ` [PATCH 13/15] Accessiblity: speakup_txprt: " Osama Muhammad
2022-11-09 21:51 ` [PATCH 14/15] Accessiblity: speakup_acntpc: " Osama Muhammad
2022-11-09 21:51 ` [PATCH 15/15] Accessiblity: speakup_acntsa: " Osama Muhammad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221109215108.7933-11-osmtendev@gmail.com \
    --to=osmtendev@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox