Re: [PATCH 4/7] dt-bindings: usb: add the Renesas USBF controller binding

Herve Codina
2022-11-07T14:50:36Z

Hi Geert,

On Mon, 7 Nov 2022 15:26:43 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Hervé,
>
> On Mon, Nov 7, 2022 at 3:00 PM Herve Codina <herve.codina@bootlin.com> wrote:
> > The Renesas USBF controller is an USB2.0 device controller
> > (UDC) available in Renesas r9a06g032 SoC (RZ/N1 family).
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
>
> Thanks for your patch!
>
[...]
> > +maintainers:
> > + - Herve Codina <herve.codina@bootlin.com>
>
> Hervé? ;-)

Sure, you're right but in all my commits, signed-off-by and
other places where my email appears, I spell Hervé as "Herve"
So, to be consistent and avoid future confusion, I prefer
to keep Herve here.

>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - renesas,r9a06g032-usbf
> > + - const: renesas,rzn1-usbf
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: Internal bus clock (AHB) for Function
> > + - description: Internal bus clock (AHB) for Power Management
> > + clock-names:
> > + items:
> > + - const: hclkf
> > + - const: hclkpm
>
> power-domains?

Will be added in v2.

Thanks for the review,
Hervé