Re: [PATCH v1 07/28] rust: macros: take string literals in `module!`

Wei Liu
2022-11-14T17:26:15Z

On Mon, Nov 14, 2022 at 05:46:05PM +0100, Miguel Ojeda wrote:
> On Mon, Nov 14, 2022 at 3:47 PM Wei Liu <wei.liu@kernel.org> wrote:
> >
> > What's the rationale behind allowing UTF-8? Why not stick with ASCII
> > only?
>
> The reason is that there are already some cases on the C side.
>
> For authors, there are about 158 non-ASCII in the kernel tree (if I
> grepped correctly), e.g.:
>
> MODULE_AUTHOR("漆鹏振 (Qi Pengzhen) <aric.pzqi@ingenic.com>");
> MODULE_AUTHOR("Martin Povišer <povik+lin@cutebit.org>");
> MODULE_AUTHOR("Jérôme Pouiller <jerome.pouiller@silabs.com>");
> MODULE_AUTHOR("Uwe Kleine-König <u.kleine-koenig@pengutronix.de>");
>
> There are also a few descriptions too, e.g.:
>
> MODULE_DESCRIPTION("NAND flash driver for OLPC CAFÉ chip");
> MODULE_DESCRIPTION("NHPoly1305 ε-almost-∆-universal hash function");

Okay. That's fair enough.

Thanks,
Wei.

>
> Cheers,
> Miguel