* [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()
@ 2022-11-10 9:26 ye.xingchen
2022-11-10 11:54 ` Mukesh Ojha
2022-11-10 15:43 ` Tudor.Ambarus
0 siblings, 2 replies; 4+ messages in thread
From: ye.xingchen @ 2022-11-10 9:26 UTC (permalink / raw)
To: vkoul
Cc: f.fainelli, bcm-kernel-feedback-list, rjui, sbranden, dmaengine,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
From: Minghao Chi <chi.minghao@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/dma/bcm2835-dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 630dfbb01a40..1547f528a58e 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()
2022-11-10 9:26 [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource() ye.xingchen
@ 2022-11-10 11:54 ` Mukesh Ojha
2022-11-10 15:43 ` Tudor.Ambarus
1 sibling, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2022-11-10 11:54 UTC (permalink / raw)
To: ye.xingchen, vkoul
Cc: f.fainelli, bcm-kernel-feedback-list, rjui, sbranden, dmaengine,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
Hi,
On 11/10/2022 2:56 PM, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/dma/bcm2835-dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 630dfbb01a40..1547f528a58e 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
>
> dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()
2022-11-10 9:26 [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource() ye.xingchen
2022-11-10 11:54 ` Mukesh Ojha
@ 2022-11-10 15:43 ` Tudor.Ambarus
1 sibling, 0 replies; 4+ messages in thread
From: Tudor.Ambarus @ 2022-11-10 15:43 UTC (permalink / raw)
To: ye.xingchen, vkoul
Cc: f.fainelli, bcm-kernel-feedback-list, rjui, sbranden, dmaengine,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
On 11/10/22 11:26, ye.xingchen@zte.com.cn wrote:
> [You don't often get email from ye.xingchen@zte.com.cn. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
Would you review my v3 instead?
https://lore.kernel.org/lkml/20221110152528.7821-1-tudor.ambarus@microchip.com/
The intention is to do this small change for all the dma drivers in a
single patch, so that we don't pollute the commit log.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/dma/bcm2835-dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 630dfbb01a40..1547f528a58e 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
>
> dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> --
> 2.25.1
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Cheers,
ta
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()
@ 2022-11-10 8:53 ye.xingchen
0 siblings, 0 replies; 4+ messages in thread
From: ye.xingchen @ 2022-11-10 8:53 UTC (permalink / raw)
To: mturquette; +Cc: sboyd, linux-clk, linux-kernel, chi.minghao
From: Minghao Chi <chi.minghao@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/dma/bcm2835-dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 630dfbb01a40..1547f528a58e 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-10 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-10 9:26 [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource() ye.xingchen
2022-11-10 11:54 ` Mukesh Ojha
2022-11-10 15:43 ` Tudor.Ambarus
-- strict thread matches above, loose matches on Subject: below --
2022-11-10 8:53 ye.xingchen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox