Re: [PATCH 06/12] perf test: Replace arm callgraph fp test workload with leafloop

James Clark
2022-11-14T11:17:33Z

On 10/11/2022 18:19, Namhyung Kim wrote:
> So that it can get rid of requirement of a compiler.
>
> Reviewed-by: Leo Yan <leo.yan@linaro.org>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> .../perf/tests/shell/test_arm_callgraph_fp.sh | 34 ++-----------------
> 1 file changed, 3 insertions(+), 31 deletions(-)

Tested-by: James Clark <james.clark@arm.com>

>
> diff --git a/tools/perf/tests/shell/test_arm_callgraph_fp.sh b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> index ec108d45d3c6..e61d8deaa0c4 100755
> --- a/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> +++ b/tools/perf/tests/shell/test_arm_callgraph_fp.sh
> @@ -4,44 +4,16 @@
>
> lscpu | grep -q "aarch64" || exit 2
>
> -if ! [ -x "$(command -v cc)" ]; then
> - echo "failed: no compiler, install gcc"
> - exit 2
> -fi
> -
> PERF_DATA=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
> -TEST_PROGRAM_SOURCE=$(mktemp /tmp/test_program.XXXXX.c)
> -TEST_PROGRAM=$(mktemp /tmp/test_program.XXXXX)
> +TEST_PROGRAM="perf test -w leafloop"
>
> cleanup_files()
> {
> rm -f $PERF_DATA
> - rm -f $TEST_PROGRAM_SOURCE
> - rm -f $TEST_PROGRAM
> }
>
> trap cleanup_files exit term int
>
> -cat << EOF > $TEST_PROGRAM_SOURCE
> -int a = 0;
> -void leaf(void) {
> - for (;;)
> - a += a;
> -}
> -void parent(void) {
> - leaf();
> -}
> -int main(void) {
> - parent();
> - return 0;
> -}
> -EOF
> -
> -echo " + Compiling test program ($TEST_PROGRAM)..."
> -
> -CFLAGS="-g -O0 -fno-inline -fno-omit-frame-pointer"
> -cc $CFLAGS $TEST_PROGRAM_SOURCE -o $TEST_PROGRAM || exit 1
> -
> # Add a 1 second delay to skip samples that are not in the leaf() function
> perf record -o $PERF_DATA --call-graph fp -e cycles//u -D 1000 --user-callchains -- $TEST_PROGRAM 2> /dev/null &
> PID=$!
> @@ -58,11 +30,11 @@ wait $PID
> # program
> # 728 leaf
> # 753 parent
> -# 76c main
> +# 76c leafloop
> # ...
>
> perf script -i $PERF_DATA -F comm,ip,sym | head -n4
> perf script -i $PERF_DATA -F comm,ip,sym | head -n4 | \
> awk '{ if ($2 != "") sym[i++] = $2 } END { if (sym[0] != "leaf" ||
> sym[1] != "parent" ||
> - sym[2] != "main") exit 1 }'
> + sym[2] != "leafloop") exit 1 }'