Re: [PATCH 03/14] phy: qcom-qmp-combo: drop v4 reference-clock source

Dmitry Baryshkov
2022-11-12T11:43:49Z

On 11/11/2022 12:24, Johan Hovold wrote:
> The source clock for the reference clock should not be described by the
> devicetree and instead this relationship should be modelled in the clock
> driver.

Do we have a fix for the gcc driver?

>
> Drop the management of the source clock from the driver for SC8180X and
> SC8280XP. Note that support for the former is not yet in mainline.
>
> Also note that the binding has never been updated to describe the v4
> clocks for SC8180X.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> index 51a03ac05c91..e6c7cf723b19 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> @@ -947,7 +947,7 @@ static const char * const qmp_v3_phy_clk_l[] = {
> };
>
> static const char * const qmp_v4_phy_clk_l[] = {
> - "aux", "ref_clk_src", "ref", "com_aux",
> + "aux", "ref", "com_aux",
> };
>
> /* the primary usb3 phy on sm8250 doesn't have a ref clock */

--
With best wishes
Dmitry