Re: [PATCH 12/14] phy: qcom-qmp-combo: rename common-register pointers

Johan Hovold
2022-11-14T12:55:26Z

On Sat, Nov 12, 2022 at 02:31:27PM +0300, Dmitry Baryshkov wrote:
> On 11/11/2022 12:24, Johan Hovold wrote:
> > The common registers are shared by the USB and DP parts of the PHY so
> > drop the misleading "dp" prefix from the corresponding pointers.
> >
> > Note that the "DP" prefix could also be dropped from the corresponding
> > defines, but leave that in place for now.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 24 +++++++++++------------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Note regarding the last phrase: I'd suggest leaving the DP prefix in
> register names, it makes it easier to visually note & verify the
> register block.

My point is that "DP" was never part of the COM register block name. The
confusion likely comes from the vendor driver naming these defines along
the lines of

USB3_DP_COM_POWER_DOWN_CTRL

Here "USB3_DP" is the common prefix for all defines that apply to both
"parts" of the PHY so the corresponding Linux define

QPHY_V3_DP_COM_POWER_DOWN_CTRL

should either include "USB3" or drop "DP".

This becomes more apparent on SC8280XP where the corresponding define
is:

USB43DP_COM_POWER_DOWN_CTRL

Johan