From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A31FEC433FE for ; Fri, 11 Nov 2022 15:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235008AbiKKPJL (ORCPT ); Fri, 11 Nov 2022 10:09:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234907AbiKKPID (ORCPT ); Fri, 11 Nov 2022 10:08:03 -0500 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E21F46A74A; Fri, 11 Nov 2022 07:06:47 -0800 (PST) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1otVcD-00037d-00; Fri, 11 Nov 2022 16:06:45 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id D41D1C116A; Fri, 11 Nov 2022 16:03:35 +0100 (CET) Date: Fri, 11 Nov 2022 16:03:35 +0100 From: Thomas Bogendoerfer To: Rongwei Zhang Cc: Ralf Baechle , Maxim Uvarov , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] MIPS: fix duplicate definitions for exported symbols Message-ID: <20221111150335.GA13465@alpha.franken.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2022 at 08:27:39PM +0800, Rongwei Zhang wrote: > Building with clang-14 fails with: > > AS arch/mips/kernel/relocate_kernel.o > :0: error: symbol 'kexec_args' is already defined > :0: error: symbol 'secondary_kexec_args' is already defined > :0: error: symbol 'kexec_start_address' is already defined > :0: error: symbol 'kexec_indirection_page' is already defined > :0: error: symbol 'relocate_new_kernel_size' is already defined > > It turns out EXPORT defined in asm/asm.h expands to a symbol definition, > so there is no need to define these symbols again. Remove duplicated > symbol definitions. > > Fixes: 7aa1c8f47e7e ("MIPS: kdump: Add support") > Signed-off-by: Rongwei Zhang > --- > arch/mips/kernel/relocate_kernel.S | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]