Re: [PATCH v8 net-next 2/2] net: dsa: mv88e6xxx: mac-auth/MAB implementation

netdev
2022-11-20T09:34:17Z

On 2022-11-15 23:23, Vladimir Oltean wrote:
>
> How much (and what) do you plan to add to switchdev.{c,h} in the
> future?
> It's a bit arbitrary to put only mv88e6xxx_handle_violation() in a file
> called switchdev.c.
>
> port_fdb_add(), port_mdb_add(), port_vlan_add(), port_vlan_filtering(),
> etc etc, are all switchdev things. Anyway.
>

Firstly, those functions you list are ops functions, while what is in
switchdev.{c,h} is not, secondly the functions in switchdev.{c,h} are
the
first to send switchdev messages like SWITCHDEV_FDB_ADD_TO_BRIDGE
events.

Furthermore I think that chip.c is bloated, but I also do plan to add
more
to switchdev.{c,h}, and there can be others adding in the future...