Re: [PATCH v4 0/7] pinctrl: intel: Enable PWM optional feature

Andy Shevchenko
2022-11-16T17:32:30Z

On Mon, Nov 14, 2022 at 06:55:38PM +0200, Andy Shevchenko wrote:
> This is a continuation of the previously applied PWM LPSS cleanup series.
> Now, we would like to enable PWM optional feature that may be embedded
> into Intel pin control IPs (starting from Sky Lake platforms).
>
> I would like to route this via Intel pin control tree with issuing
> an immutable branch for both PINCTRL and PWM subsystems, but I'm
> open for other suggestions.
>
> Hans, I dared to leave your Rb tags, however the patches are slightly
> differ, because of the Uwe's suggestion on how to handle the missing
> headers. I hope you are okay with that. If not, please comment what
> must be amended then.

Uwe, it would be nice if you have a chance to look at this one more time.
If it is okay, I can push it to an immutable branch and send out for all
stakeholders.

> Changelog v4:
> - added patch "Rename pwm_lpss_probe() --> devm_pwm_lpss_probe()"
>
> Changelog v3:
> - added tags (Uwe, Linus, Thierry)
> - fixed some spelling issues in the commit messages
> - changed a paragraph in the commit message of the patch 3 (Uwe)
> - replaced -ENODEV check with IS_REACHABLE() in the patch 6 (Uwe)
>
> Changelog v2:
> - added tag (Mika)
> - added base-commit to the series, to make sure LKP can test it
>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Andy Shevchenko (7):
> pwm: Add a stub for devm_pwmchip_add()
> pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMS
> pwm: lpss: Include headers we are the direct user of
> pwm: lpss: Allow other drivers to enable PWM LPSS
> pwm: lpss: Rename pwm_lpss_probe() --> devm_pwm_lpss_probe()
> pwm: lpss: Add devm_pwm_lpss_probe() stub
> pinctrl: intel: Enumerate PWM device when community has a capability
>
> drivers/pinctrl/intel/pinctrl-intel.c | 32 ++++++++++++++++
> drivers/pwm/pwm-lpss-pci.c | 2 +-
> drivers/pwm/pwm-lpss-platform.c | 2 +-
> drivers/pwm/pwm-lpss.c | 8 ++--
> drivers/pwm/pwm-lpss.h | 34 ++++-------------
> include/linux/platform_data/x86/pwm-lpss.h | 44 ++++++++++++++++++++++
> include/linux/pwm.h | 5 +++
> 7 files changed, 95 insertions(+), 32 deletions(-)
> create mode 100644 include/linux/platform_data/x86/pwm-lpss.h
>
>
> base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
> --
> 2.35.1
>

--
With Best Regards,
Andy Shevchenko