RE: [patch 15/20] genirq/msi: Provide new domain id allocation functions

Tian, Kevin
2022-11-21T03:26:20Z

> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Friday, November 18, 2022 8:26 PM
>
> >> + xa_for_each_range(xa, idx, desc, ctrl->first + base, ctrl->last + base) {
> >> + if (!msi_desc_match(desc, MSI_DESC_NOTASSOCIATED))
> >> + continue;
> >> +
> >> + /* This should return -ECONFUSED... */
> >> + if (WARN_ON_ONCE(allocated >= ctrl->nirqs))
> >> + return -EINVAL;
> >> +
> >
> > why is "==" an error?
>
> because if you get here _after_ having allocated all interrupts already
> then you have more descriptors than what you want to allocate, which
> should never happen right?

yes