RE: [patch 12/20] genirq/msi: Make descriptor freeing domain aware

Thomas Gleixner
2022-11-18T13:10:13Z

On Fri, Nov 18 2022 at 13:22, Thomas Gleixner wrote:
> On Fri, Nov 18 2022 at 08:17, Kevin Tian wrote:
>>> - lockdep_assert_held(&dev->msi.data->mutex);
>>> + base = msi_get_domain_base_index(dev, ctrl->domid);
>>> + if (base < 0)
>>> + return;
>>
>> What about putting domid checks in msi_ctrl_valid() then here could
>> be a simple calculation on domid * MSI_XA_DOMAIN_SIZE.

I need the base domain index w/o the ctrl thing too.

>> domid is part of msi_ctrl. then it sound reasonable to validate it
>> together with first/last.
>
> Let me look at that.

So I kept it as is, but renamed msi_ctrl_valid() to
msi_ctrl_range_valid().

Thanks,

tglx