Re: [patch 16/20] PCI/MSI: Use msi_domain_alloc/free_irqs_all_locked()

Bjorn Helgaas
2022-11-14T17:13:10Z

On Fri, Nov 11, 2022 at 02:57:03PM +0100, Thomas Gleixner wrote:
> Switch to the new domain id aware interfaces to phase out the previous
> ones. No functional change.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
> drivers/pci/msi/irqdomain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -14,7 +14,7 @@ int pci_msi_setup_msi_irqs(struct pci_de
>
> domain = dev_get_msi_domain(&dev->dev);
> if (domain && irq_domain_is_hierarchy(domain))
> - return msi_domain_alloc_irqs_descs_locked(domain, &dev->dev, nvec);
> + return msi_domain_alloc_irqs_all_locked(&dev->dev, MSI_DEFAULT_DOMAIN, nvec);
>
> return pci_msi_legacy_setup_msi_irqs(dev, nvec, type);
> }
> @@ -25,7 +25,7 @@ void pci_msi_teardown_msi_irqs(struct pc
>
> domain = dev_get_msi_domain(&dev->dev);
> if (domain && irq_domain_is_hierarchy(domain)) {
> - msi_domain_free_irqs_descs_locked(domain, &dev->dev);
> + msi_domain_free_irqs_all_locked(&dev->dev, MSI_DEFAULT_DOMAIN);
> } else {
> pci_msi_legacy_teardown_msi_irqs(dev);
> msi_free_msi_descs(&dev->dev);
>