Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

Eric DeVolder
2022-12-08T19:05:35Z

On 12/7/22 04:15, Borislav Petkov wrote:
> On Wed, Nov 16, 2022 at 04:46:39PM -0500, Eric DeVolder wrote:
>> +#ifndef arch_map_crash_pages
>> +/*
>> + * NOTE: The addresses and sizes passed to this routine have
>> + * already been fully aligned on page boundaries. There is no
>> + * need for massaging the address or size.
>> + */
>> +static inline void *arch_map_crash_pages(unsigned long paddr,
>> + unsigned long size)
>> +{
>> + if (size > 0)
>> + return kmap_local_page(pfn_to_page(paddr >> PAGE_SHIFT));
>> + else
>> + return NULL;
>> +}
>> +#endif
>> +
>> +#ifndef arch_unmap_crash_pages
>> +static inline void arch_unmap_crash_pages(void *ptr)
>> +{
>> + if (ptr)
>> + kunmap_local(ptr);
>> +}
>> +#endif
>
> Why is that function still here and why aren't you calling
> kmap_local_page() simply?
>

Corrected!
eric