Re: [PATCH v2 13/14] Documentation/ABI: Update IFS ABI doc

Sohil Mehta
2022-11-09T23:55:16Z

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> Remove reload documentation and add current_batch documentation.
> Update the kernel version and date for all the entries.
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>

A clarification below.

>
> -What: /sys/devices/virtual/misc/intel_ifs_<N>/reload
> -Date: April 21 2022
> -KernelVersion: 5.19
> +What: /sys/devices/virtual/misc/intel_ifs_<N>/current_batch
> +Date: Sept 30 2022
> +KernelVersion: 6.2
> Contact: "Jithu Joseph" <jithu.joseph@intel.com>
> -Description: Write "1" (or "y" or "Y") to reload the IFS image from
> - /lib/firmware/intel/ifs/ff-mm-ss.scan.
> +Description: Write a number less than or equal to 0xff to load an IFS test image.

Can the number start from 0 or is it expected to start from 1? It might
be useful to mention that if there is a constraint.

> + The number written treated as the 2 digit suffix in the following file name:
> + /lib/firmware/intel/ifs_<N>/ff-mm-ss-02x.scan
> + Reading the file will provide the suffix of the currently loaded IFS test image.

Sohil