Re: [PATCH v3 04/16] platform/x86/intel/ifs: Remove memory allocation from load path

Joseph, Jithu
2022-11-17T22:44:53Z

On 11/17/2022 1:13 PM, Hans de Goede wrote:
> Hi,
>
> On 11/17/22 20:59, Jithu Joseph wrote:
>> IFS requires tests to be authenticated once for each CPU socket
>> on a system.
>>
>> scan_chunks_sanity_check() was dynamically allocating memory
>> to store the state of whether tests have been authenticated on
>> each socket for every load operation.
>>
>> Move the memory allocation to init path and store the pointer
>> in ifs_data struct.
>>
>> Also rearrange the adjacent error checking in init for a
>> more simplified and natural flow.
>>
>> Reviewed-by: Tony Luck <tony.luck@intel.com>
>> Suggested-by: Borislav Petkov <bp@alien8.de>
>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
>> ---
>> - Replaced global pkg_auth pointer to struct ifs_data (Hans)
>> - Rearrange the adjacent error checking flow in ifs_init (Hans)
>> - With this change there are conflicts in patches 11 and 12 (I will
>> post the updated 11 and 12 if this is satisfactory)
>
> Thanks, this patch looks good to me now:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>

Thanks for the detailed review and suggestions.
I will now resend patches 11 and 12 which will apply ontop of this revised patch4 .

Jithu