Re: [PATCH v2 14/14] Revert "platform/x86/intel/ifs: Mark as BROKEN"

Hans de Goede
2022-11-10T21:35:17Z

Hi,

On 11/7/22 23:53, Jithu Joseph wrote:
> Issues with user interface [1] to load scan test images
> has been addressed, so the following can be reverted.
> commit c483e7ea10fa ("platform/x86/intel/ifs: Mark as BROKEN")
>
> Link: https://lore.kernel.org/lkml/26102aca-a730-ddf8-d024-2e7367696757@redhat.com/ [1]
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
> drivers/platform/x86/intel/ifs/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/ifs/Kconfig b/drivers/platform/x86/intel/ifs/Kconfig
> index 89152d46deee..3eded966757e 100644
> --- a/drivers/platform/x86/intel/ifs/Kconfig
> +++ b/drivers/platform/x86/intel/ifs/Kconfig
> @@ -1,9 +1,6 @@
> config INTEL_IFS
> tristate "Intel In Field Scan"
> depends on X86 && CPU_SUP_INTEL && 64BIT && SMP
> - # Discussion on the list has shown that the sysfs API needs a bit
> - # more work, mark this as broken for now
> - depends on BROKEN
> help
> Enable support for the In Field Scan capability in select
> CPUs. The capability allows for running low level tests via