From: Guenter Roeck <linux@roeck-us.net>
To: Matthew Dawson <matthew@mjdsystems.ca>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
Eugene Shalygin <eugene.shalygin@gmail.com>
Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add definitions for ROG ZENITH II EXTREME ALPHA
Date: Sun, 20 Nov 2022 06:00:57 -0800 [thread overview]
Message-ID: <20221120140057.GA1788720@roeck-us.net> (raw)
In-Reply-To: <2407243.vFx2qVVIhK@cwmtaff>
On Fri, Nov 18, 2022 at 10:36:22AM -0500, Matthew Dawson wrote:
> Add support for the Zenith II Extreme Alpha. It is basically the same
> board as the Zenith II Extreme, and has a similar sensor suite. The
> DSDT is basically the same except for some address, so use the same
> board information as the non-Alpha board.
>
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Matthew Dawson <matthew@mjdsystems.ca>
> ---
> v2: Add missing Documentation change
>
> Documentation/hwmon/asus_ec_sensors.rst | 1 +
> drivers/hwmon/asus-ec-sensors.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/Documentation/hwmon/asus_ec_sensors.rst b/Documentation/hwmon/
> asus_ec_sensors.rst
Your patch is corrupted. The line above is split. If I try to fix that, I get
error: patch failed: drivers/hwmon/asus-ec-sensors.c:466
error: drivers/hwmon/asus-ec-sensors.c: patch does not apply
error: Did you hand edit your patch?
It looks like tabs were raplaced with spaces. Please fix and resubmit.
Thanks,
Guenter
> index 02f4ad314a1e..a4039f2f9ca4 100644
> --- a/Documentation/hwmon/asus_ec_sensors.rst
> +++ b/Documentation/hwmon/asus_ec_sensors.rst
> @@ -23,6 +23,7 @@ Supported boards:
> * ROG STRIX X570-I GAMING
> * ROG STRIX Z690-A GAMING WIFI D4
> * ROG ZENITH II EXTREME
> + * ROG ZENITH II EXTREME ALPHA
>
> Authors:
> - Eugene Shalygin <eugene.shalygin@gmail.com>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 81e688975c6a..ac0459be04c7 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -466,6 +466,8 @@ static const struct dmi_system_id dmi_table[] = {
> &board_info_strix_z690_a_gaming_wifi_d4),
> DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG ZENITH II EXTREME",
> &board_info_zenith_ii_extreme),
> + DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG ZENITH II EXTREME ALPHA",
> + &board_info_zenith_ii_extreme),
> {},
> };
>
prev parent reply other threads:[~2022-11-20 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 15:36 [PATCH v2] hwmon: (asus-ec-sensors) add definitions for ROG ZENITH II EXTREME ALPHA Matthew Dawson
2022-11-20 14:00 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221120140057.GA1788720@roeck-us.net \
--to=linux@roeck-us.net \
--cc=eugene.shalygin@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@mjdsystems.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox