From: Christoph Hellwig <hch@lst.de>
To: Jinlong Chen <nickyc975@zju.edu.cn>
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] elevator: restore old io scheduler on failure in elevator_switch
Date: Mon, 21 Nov 2022 08:13:05 +0100 [thread overview]
Message-ID: <20221121071305.GB23882@lst.de> (raw)
In-Reply-To: <cover.1668772991.git.nickyc975@zju.edu.cn>
On Fri, Nov 18, 2022 at 08:09:52PM +0800, Jinlong Chen wrote:
> elevator_switch contains the fallback logic in sq era, but it was removed
> when moving to mq (commit: a1ce35fa49852db60fc6e268038530be533c5b15),
> leaving the document mismatched with the behavior. As far as I can see,
> restoring the old io scheduler is more reasonable than just leaving the
> scheduler none, hence there is the series.
What failure scenariou can you think off where switching to the intended
schedule fails, but switching back to the previous one will succeed?
next prev parent reply other threads:[~2022-11-21 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 12:09 [RFC PATCH 0/2] elevator: restore old io scheduler on failure in elevator_switch Jinlong Chen
2022-11-18 12:09 ` [RFC PATCH 1/2] elevator: add a helper for applying scheduler to request_queue Jinlong Chen
2022-11-18 12:09 ` [RFC PATCH 2/2] elevator: restore the old io scheduler if failed to switch to the new one Jinlong Chen
2022-11-21 7:13 ` Christoph Hellwig [this message]
2022-11-22 12:14 ` [RFC PATCH 0/2] elevator: restore old io scheduler on failure in elevator_switch Jinlong Chen
2022-11-22 12:24 ` Christoph Hellwig
2022-11-22 12:44 ` Jinlong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121071305.GB23882@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickyc975@zju.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox