public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Christoph Hellwig <hch@lst.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.de>
Subject: Re: linux-next: manual merge of the dma-mapping tree with Linus' tree
Date: Tue, 22 Nov 2022 07:11:58 +0100	[thread overview]
Message-ID: <20221122061158.GA14175@lst.de> (raw)
In-Reply-To: <20221122100611.13a374e2@canb.auug.org.au>

On Tue, Nov 22, 2022 at 10:06:11AM +1100, Stephen Rothwell wrote:
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.

Thanks Stephen,

the fix look good.  The being said the code in the sound tree here
is questionable to start with:

>   #ifdef CONFIG_SND_DMA_SGBUF
>  +	if (!sgt && !get_dma_ops(dmab->dev.dev)) {
>   		if (dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC_SG)
>   			dmab->dev.type = SNDRV_DMA_TYPE_DEV_WC_SG_FALLBACK;
>   		else

driver have no busuness calling get_dma_ops and poking into the
dma-mapping internals.

  reply	other threads:[~2022-11-22  6:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 23:06 linux-next: manual merge of the dma-mapping tree with Linus' tree Stephen Rothwell
2022-11-22  6:11 ` Christoph Hellwig [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-06-30 22:42 Stephen Rothwell
2019-07-09  0:16 ` Stephen Rothwell
2019-03-05 21:36 Stephen Rothwell
2018-05-29 23:20 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221122061158.GA14175@lst.de \
    --to=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox