From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: <linux-cxl@vger.kernel.org>, <dan.j.williams@intel.com>,
<bwidawsk@kernel.org>, <ira.weiny@intel.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<a.manzanares@samsung.com>, <mcgrof@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] cxl/mbox: Add background operation handling machinery
Date: Tue, 22 Nov 2022 09:44:22 +0000 [thread overview]
Message-ID: <20221122094422.000032f0@Huawei.com> (raw)
In-Reply-To: <20221121214804.zy6i5basztlim66t@offworld>
On Mon, 21 Nov 2022 13:48:04 -0800
Davidlohr Bueso <dave@stgolabs.net> wrote:
> On Thu, 25 Aug 2022, Jonathan Cameron wrote:
>
> >> +/*
> >> + * Ensure that ->mbox_send() can run safely when a background
> >> + * command is running. If so, returns zero, otherwise -EBUSY.
> >
> >As above, I'm not sure this is necessary given you should get
> >a sensible error code in response to any such message.
> >E.g. media disabled.
>
> So this is necessary to prevent mischief in the polling case
> where you can have windows where the driver is out of sync
> with the hardware - hw finishes async command but driver
> (sleeping poller) has not acknowledged this. In the irq case,
> yeah this would be redundant and not needed.
>
Ok. A worked example might be useful for where this matters
at a higher level. For example, if there is no conflict at
the hardware level what goes wrong in the software as a result
of dropping the protection on the one that we haven't yet detected
as finished...
Jonathan
> Thanks,
> Davidlohr
next prev parent reply other threads:[~2022-11-22 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 4:50 [RFC PATCH 0/2] cxl: BG operations and device sanitation Davidlohr Bueso
2022-08-04 4:36 ` Davidlohr Bueso
2022-08-04 4:50 ` [PATCH 1/2] cxl/mbox: Add background operation handling machinery Davidlohr Bueso
2022-08-25 12:41 ` Jonathan Cameron
2022-11-21 21:48 ` Davidlohr Bueso
2022-11-22 9:44 ` Jonathan Cameron [this message]
2022-08-04 4:50 ` [PATCH 2/2] cxl/mem: Support sanitation commands Davidlohr Bueso
2022-08-25 14:08 ` Jonathan Cameron
2022-08-04 18:13 ` [RFC PATCH 0/2] cxl: BG operations and device sanitation Dave Jiang
2022-08-04 20:07 ` Davidlohr Bueso
2022-08-08 20:52 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122094422.000032f0@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=a.manzanares@samsung.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox