From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2836DC433FE for ; Tue, 22 Nov 2022 18:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234250AbiKVSe0 (ORCPT ); Tue, 22 Nov 2022 13:34:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232869AbiKVSeX (ORCPT ); Tue, 22 Nov 2022 13:34:23 -0500 Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39CF17C6B5; Tue, 22 Nov 2022 10:34:22 -0800 (PST) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 6C08C2800BBC5; Tue, 22 Nov 2022 19:34:20 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 5F64AA072B; Tue, 22 Nov 2022 19:34:20 +0100 (CET) Date: Tue, 22 Nov 2022 19:34:20 +0100 From: Lukas Wunner To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , Rodrigo Vivi , LKML , Linux ACPI , Linux PCI , Linux PM , Mika Westerberg Subject: Re: [PATCH v1 0/2] PCI: hotplug: Add checks to avoid doing hotplug on PCIe Upstream Ports Message-ID: <20221122183420.GA22578@wunner.de> References: <5623410.DvuYhMxLoT@kreacher> <20221122180603.GA205176@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221122180603.GA205176@bhelgaas> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 22, 2022 at 12:06:03PM -0600, Bjorn Helgaas wrote: > On Mon, Nov 21, 2022 at 07:13:15PM +0100, Rafael J. Wysocki wrote: > > PCIe Upstream Ports are not hotplug-capable by definition, but it turns out > > that in some cases, if the system is configured in a particularly interesting > > way, the kernel may be made attempt to operate an Upstream Port as a hotplug > > one which causes functional issues to appear. > > > > The following 2 patches amend the code to prevent this behavior from occurring. > > Thanks, applied to pci/hotplug for v6.2. Lukas, I didn't presume to > convert your LGTM to Reviewed-by, but would be happy add it. I figured that having both a Suggested-by and a Reviewed-by might look odd, hence went with the more neutral LGTM. But I see it was ambiguous. Either way is fine for me. :) Thanks, Lukas