From: Max Staudt <max@enpas.org>
To: <wg@grandegger.com>, <mkl@pengutronix.de>
Cc: "Ziyang Xuan (William)" <william.xuanziyang@huawei.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <linux-can@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH] can: can327: fix potential skb leak when netdev is down
Date: Tue, 22 Nov 2022 19:09:11 +0900 [thread overview]
Message-ID: <20221122190911.4a272f5a.max@enpas.org> (raw)
In-Reply-To: <cd51300f-34cc-3222-7bd9-ec349b9cd603@huawei.com>
Marc, Wolfgang,
Could you please include William's patch to can327, provided that you
see no issue with it?
Thanks :)
Max
On Tue, 22 Nov 2022 10:10:50 +0800
"Ziyang Xuan (William)" <william.xuanziyang@huawei.com> wrote:
> Hello,
>
> Gently ask.
>
> Is there any other problem? And can it be applied?
>
> Thanks.
>
> > (CC Vincent, he may be interested)
> >
> >
> > On Thu, 10 Nov 2022 14:14:37 +0800
> > Ziyang Xuan <william.xuanziyang@huawei.com> wrote:
> >
> >> Fix it by adding kfree_skb() in can327_feed_frame_to_netdev() when netdev
> >> is down. Not tested, just compiled.
> >
> > Looks correct to me, so:
> >
> > Reviewed-by: Max Staudt <max@enpas.org>
> >
> >
> > Thank you very much for finding and fixing this!
> >
> > Max
> >
> > .
> >
prev parent reply other threads:[~2022-11-22 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 6:14 [PATCH] can: can327: fix potential skb leak when netdev is down Ziyang Xuan
2022-11-10 16:04 ` Max Staudt
2022-11-22 2:10 ` Ziyang Xuan (William)
2022-11-22 10:09 ` Max Staudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122190911.4a272f5a.max@enpas.org \
--to=max@enpas.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wg@grandegger.com \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox