From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3B556C43217
	for <linux-kernel@archiver.kernel.org>; Tue, 22 Nov 2022 10:10:13 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232416AbiKVKKL (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 22 Nov 2022 05:10:11 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36522 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229449AbiKVKKH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Nov 2022 05:10:07 -0500
Received: from mail.enpas.org (zhong.enpas.org [IPv6:2a03:4000:2:537::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8580A13D15;
        Tue, 22 Nov 2022 02:10:06 -0800 (PST)
Received: from [127.0.0.1] (localhost [127.0.0.1])
        by mail.enpas.org (Postfix) with ESMTPSA id AC0FCFF9E2;
        Tue, 22 Nov 2022 10:10:01 +0000 (UTC)
Date:   Tue, 22 Nov 2022 19:09:11 +0900
From:   Max Staudt <max@enpas.org>
To:     <wg@grandegger.com>, <mkl@pengutronix.de>
Cc:     "Ziyang Xuan (William)" <william.xuanziyang@huawei.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <linux-can@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH] can: can327: fix potential skb leak when netdev is down
Message-ID: <20221122190911.4a272f5a.max@enpas.org>
In-Reply-To: <cd51300f-34cc-3222-7bd9-ec349b9cd603@huawei.com>
References: <20221110061437.411525-1-william.xuanziyang@huawei.com>
        <20221111010412.6ca0ff1c.max@enpas.org>
        <cd51300f-34cc-3222-7bd9-ec349b9cd603@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Marc, Wolfgang,

Could you please include William's patch to can327, provided that you
see no issue with it?


Thanks :)

Max




On Tue, 22 Nov 2022 10:10:50 +0800
"Ziyang Xuan (William)" <william.xuanziyang@huawei.com> wrote:

> Hello,
> 
> Gently ask.
> 
> Is there any other problem? And can it be applied?
> 
> Thanks.
> 
> > (CC Vincent, he may be interested)
> > 
> > 
> > On Thu, 10 Nov 2022 14:14:37 +0800
> > Ziyang Xuan <william.xuanziyang@huawei.com> wrote:
> >   
> >> Fix it by adding kfree_skb() in can327_feed_frame_to_netdev() when netdev
> >> is down. Not tested, just compiled.  
> > 
> > Looks correct to me, so:
> > 
> > Reviewed-by: Max Staudt <max@enpas.org>
> > 
> > 
> > Thank you very much for finding and fixing this!
> > 
> > Max
> > 
> > .
> >