Re: [PATCH net-next v3 2/5] mlxsw: core: fix mlxsw_devlink_info_get() to correctly report driver name

Vincent MAILHOL
2022-11-28T01:42:44Z

On Mon. 28 Nov. 2022 at 01:17, Ido Schimmel <idosch@nvidia.com> wrote:
> On Sun, Nov 27, 2022 at 10:09:16PM +0900, Vincent Mailhol wrote:
> > Currently, mlxsw_devlink_info_get() reports the device_kind. The
> > device_kind is not necessarily the same as the device_name. For
> > example, the mlxsw_i2c implementation sets up the device_kind as
> > ic2_client::name in [1] which indicates the type of the device
>
> s/ic2/i2c/
>
> > (e.g. chip name).
> >
> > Fix it so that it correctly reports the driver name.
> >
> > [1] mlxsw_i2c_probe() from drivers/net/ethernet/mellanox/mlxsw/i2c.c
> > Link: https://elixir.bootlin.com/linux/v6.1-rc1/source/drivers/net/ethernet/mellanox/mlxsw/i2c.c#L714
>
> Same comment as before.
>
> Before the series:
>
> # devlink dev info i2c/2-0048 | grep driver
> driver mlxsw_minimal
>
> After the series:
>
> # devlink dev info i2c/2-0048 | grep driver
> driver mlxsw_minimal

ACK. I was overall confused by the device_kind. Thank you for your
confirmation. I will drop the first two patches from this series.

Yours sincerely,
Vincent Mailhol