Re: [PATCH net-next v4 3/3] net: devlink: make the devlink_ops::info_get() callback optional

Jakub Kicinski
2022-11-28T18:42:16Z

On Mon, 28 Nov 2022 13:15:45 +0900 Vincent Mailhol wrote:
> Some drivers only reported the driver name in their
> devlink_ops::info_get() callback. Now that the core provides this
> information, the callback became empty. For such drivers, just
> removing the callback would prevent the core from executing
> devlink_nl_info_fill() meaning that "devlink dev info" would not
> return anything.
>
> Make the callback function optional by executing
> devlink_nl_info_fill() even if devlink_ops::info_get() is NULL.
>
> Remove all the empty devlink_ops::info_get() functions from the
> drivers.
>
> N.B.: the drivers with devlink support which previously did not
> implement devlink_ops::info_get() will now also be able to report
> the driver name.

These should be two separate patches, tho.
Please don't post v5 in-reply-to.

Otherwise looks good. Kinda risky but good :)