Re: [RFC PATCH] net: devlink: devlink_nl_info_fill: populate default information

Vincent MAILHOL
2022-11-28T23:14:27Z

On Tue. 29 Nov. 2022 at 03:43, Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 24 Nov 2022 14:33:58 +0900 Vincent MAILHOL wrote:
> > > I think 2/ is best because it will generalize to serial numbers while
> > > 1/ will likely not. 3/ is a smaller gain.
> > >
> > > Jiri already plumbed thru the struct devlink_info_req which is on the
> > > stack of the caller, per request, so we can add the bool / bitmap for
> > > already reported items there quite easily.
> >
> > Sorry, let me clarify the next actions. Are you meaning that Jiri is
> > already working on the bitmap implementation and should I wait for his
> > patches first? Or do you expect me to do it?
>
> Dunno if the question still stands but we already have
> struct devlink_info_req and can put the bitmap in it.
> All drivers use devlink helpers to add attributes.

Roger that. I already wrote the code, I just need to do a bit of
ironing and extra testing. I will send it after the "net: devlink:
devlink_nl_info_fill: populate default information" series gets
merged.