From: Stephen Boyd <sboyd@kernel.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
mturquette@baylibre.com
Cc: Robert Marko <robimarko@gmail.com>,
Christian Marangi <ansuelsmth@gmail.com>
Subject: Re: [PATCH v2] clk: qcom: ipq8074: populate fw_name for all parents
Date: Tue, 22 Nov 2022 18:30:23 -0800 [thread overview]
Message-ID: <20221123023027.487A7C433D7@smtp.kernel.org> (raw)
In-Reply-To: <20221116214655.1116467-1-robimarko@gmail.com>
Quoting Robert Marko (2022-11-16 13:46:55)
> It appears that having only .name populated in parent_data for clocks
> which are only globally searchable currently will not work as the clk core
> won't copy that name if there is no .fw_name present as well.
>
> So, populate .fw_name for all parent clocks in parent_data.
>
> Fixes: ae55ad32e273 ("clk: qcom: ipq8074: convert to parent data")
>
> Co-developed-by: Christian Marangi <ansuelsmth@gmail.com>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> Changes in v2:
> * Add fw_name for PCIe PHY pipe clocks as well
> ---
> drivers/clk/qcom/gcc-ipq8074.c | 52 +++++++++++++++++-----------------
> 1 file changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> index d231866804f6..8374cc40915a 100644
> --- a/drivers/clk/qcom/gcc-ipq8074.c
> +++ b/drivers/clk/qcom/gcc-ipq8074.c
> @@ -680,7 +680,7 @@ static struct clk_rcg2 pcie0_aux_clk_src = {
> };
>
> static const struct clk_parent_data gcc_pcie20_phy0_pipe_clk_xo[] = {
> - { .name = "pcie20_phy0_pipe_clk" },
> + { .fw_name = "pcie0_pipe", .name = "pcie20_phy0_pipe_clk" },
Is there a DT binding update for these firmware names?
next prev parent reply other threads:[~2022-11-23 2:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 21:46 [PATCH v2] clk: qcom: ipq8074: populate fw_name for all parents Robert Marko
2022-11-23 2:30 ` Stephen Boyd [this message]
2022-11-23 9:24 ` Robert Marko
2022-12-02 20:58 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123023027.487A7C433D7@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox