From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B27CAC4167D for ; Sat, 26 Nov 2022 00:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230092AbiKZAeg (ORCPT ); Fri, 25 Nov 2022 19:34:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbiKZAee (ORCPT ); Fri, 25 Nov 2022 19:34:34 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 900F62C662; Fri, 25 Nov 2022 16:34:33 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D06A32B; Fri, 25 Nov 2022 16:34:39 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 288A13F587; Fri, 25 Nov 2022 16:34:31 -0800 (PST) Date: Sat, 26 Nov 2022 00:32:40 +0000 From: Andre Przywara To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , LABBE Corentin , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org Subject: Re: [PATCH 3/3] dt-bindings: net: sun8i-emac: Add phy-supply property Message-ID: <20221126003240.3627e59f@slackpad.lan> In-Reply-To: <20221125202008.64595-4-samuel@sholland.org> References: <20221125202008.64595-1-samuel@sholland.org> <20221125202008.64595-4-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Nov 2022 14:20:08 -0600 Samuel Holland wrote: > This property has always been supported by the Linux driver; see > commit 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i"). In fact, the > original driver submission includes the phy-supply code but no mention > of it in the binding, so the omission appears to be accidental. In > addition, the property is documented in the binding for the previous > hardware generation, allwinner,sun7i-a20-gmac. > > Document phy-supply in the binding to fix devicetree validation for the > 25+ boards that already use this property. > > Fixes: 0441bde003be ("dt-bindings: net-next: Add DT bindings documentation for Allwinner dwmac-sun8i") > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > index 34a47922296d..4f671478b288 100644 > --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > @@ -42,6 +42,9 @@ properties: > clock-names: > const: stmmaceth > > + phy-supply: > + description: PHY regulator > + > syscon: > $ref: /schemas/types.yaml#/definitions/phandle > description: