From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6299BC4332F for ; Mon, 28 Nov 2022 17:51:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234025AbiK1Rvq (ORCPT ); Mon, 28 Nov 2022 12:51:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233414AbiK1Rr6 (ORCPT ); Mon, 28 Nov 2022 12:47:58 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD2802A957; Mon, 28 Nov 2022 09:43:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 210CFB80E97; Mon, 28 Nov 2022 17:43:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8ACFDC433D6; Mon, 28 Nov 2022 17:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669657380; bh=QxNAc1PgWAVXXgZf7aGU/S81aJTaX8ON1GhIJjkIpyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jdWVl2QQzVm8kwPTyq99WBZKDrgxbgSpPSUS6BOcdF954eHBLAsE6dQbydOjoLu5e oCPF1QviLFIiRVOYLU8qmkVZe0ic/FjERvNHkr2riAC9AjYcH5crgbNYAhkWCGug6E pf4Ni5yMNrO+JqRiSU+/wHYRbR7eRAjr4TY+djDpS/MUvC7b0GAfKC8dLtqd8vsih8 Y97PWnaI3lF0rJwYORqH0cdbQctdJ6xC51zn4SGHZs1PXYbOoqBxOgqNMmlbjEbO8v wFHH2d9d6x8bdh65bJiZkd/Oxw+yboNrpenWj3FleDVQ26Wsd3CGeQ03en/+xScy5Z HYA75AIibOmbA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dominique Martinet , Stefano Stabellini , Christian Schoenebeck , Sasha Levin , ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 11/12] 9p/xen: check logical size for buffer size Date: Mon, 28 Nov 2022 12:42:34 -0500 Message-Id: <20221128174235.1442841-11-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221128174235.1442841-1-sashal@kernel.org> References: <20221128174235.1442841-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dominique Martinet [ Upstream commit 391c18cf776eb4569ecda1f7794f360fe0a45a26 ] trans_xen did not check the data fits into the buffer before copying from the xen ring, but we probably should. Add a check that just skips the request and return an error to userspace if it did not fit Tested-by: Stefano Stabellini Reviewed-by: Christian Schoenebeck Link: https://lkml.kernel.org/r/20221118135542.63400-1-asmadeus@codewreck.org Signed-off-by: Dominique Martinet Signed-off-by: Sasha Levin --- net/9p/trans_xen.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c index ac60ddfcd88b..6459c2356ff9 100644 --- a/net/9p/trans_xen.c +++ b/net/9p/trans_xen.c @@ -230,6 +230,14 @@ static void p9_xen_response(struct work_struct *work) continue; } + if (h.size > req->rc.capacity) { + dev_warn(&priv->dev->dev, + "requested packet size too big: %d for tag %d with capacity %zd\n", + h.size, h.tag, req->rc.capacity); + req->status = REQ_STATUS_ERROR; + goto recv_error; + } + memcpy(&req->rc, &h, sizeof(h)); req->rc.offset = 0; @@ -239,6 +247,7 @@ static void p9_xen_response(struct work_struct *work) masked_prod, &masked_cons, XEN_9PFS_RING_SIZE); +recv_error: virt_mb(); cons += h.size; ring->intf->in_cons = cons; -- 2.35.1