The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: <zhang.songyi@zte.com.cn>
To: <rostedt@goodmis.org>
Cc: <mhiramat@kernel.org>, <linux-kernel@vger.kernel.org>,
	<zhang.songyi@zte.com.cn>
Subject: [PATCH linux-next] tracing: move from strlcpy with unused retval to strscpy
Date: Mon, 28 Nov 2022 20:02:15 +0800 (CST)	[thread overview]
Message-ID: <202211282002156712454@zte.com.cn> (raw)

From: zhang songyi <zhang.songyi@zte.com.cn>

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. That's now the recommended way to copy NUL terminated
strings. Conversion is 1:1 because the return value is not used.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
 kernel/trace/trace_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 3bfaf560ecc4..a43be36c489e 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -2813,7 +2813,7 @@ static __init int setup_trace_triggers(char *str)
        char *buf;
        int i;

-       strlcpy(bootup_trigger_buf, str, COMMAND_LINE_SIZE);
+       strscpy(bootup_trigger_buf, str, COMMAND_LINE_SIZE);
        ring_buffer_expanded = true;
        disable_tracing_selftest("running event triggers");

--
2.15.2

                 reply	other threads:[~2022-11-28 12:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202211282002156712454@zte.com.cn \
    --to=zhang.songyi@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox