From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5C8C433FE for ; Wed, 30 Nov 2022 11:50:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232979AbiK3LuF (ORCPT ); Wed, 30 Nov 2022 06:50:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232803AbiK3LuA (ORCPT ); Wed, 30 Nov 2022 06:50:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65D7745ED7 for ; Wed, 30 Nov 2022 03:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669808930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ew+rmcqxH2n7lRVyzxgZ+S2EuF0zHGkt1auf+7rBZUw=; b=UxS/1py11EMlBN0d4lkmGj8d1fllh7UiqnlrJtbSyql+04WcxbXYcknN3Qgh9j7fcKfK+/ nvN7dSQHbcvbAbCw/ufHpVTgJY2NMsgFi+pLwG68yZufgNl7PvMGasKjAhMN9MXcVLNX8x i62Eku7pKwbBVjsgH/DL1wJ1jOjW39c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-65-tly6VkSKM_md4_6rNPsalQ-1; Wed, 30 Nov 2022 06:48:40 -0500 X-MC-Unique: tly6VkSKM_md4_6rNPsalQ-1 Received: by mail-wm1-f70.google.com with SMTP id m17-20020a05600c3b1100b003cf9cc47da5so9278103wms.9 for ; Wed, 30 Nov 2022 03:48:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ew+rmcqxH2n7lRVyzxgZ+S2EuF0zHGkt1auf+7rBZUw=; b=L3l5MnTh+3JtSRdH0dcfrii7235Ef457GXC0VMIzQxpGb4BYKdZ7ToWQKiGqzv5dQB aXS2mwgPcEq7Gij8aX1WvTBXzEvgAFMn+DGz0BBlSAhvApPOzz/uV1QTb8TCc+sLMrWi 1WcJhzPUuK11hxG1z2swTWS3+SrXtVJgpjtBG8jozvlOJEo6Glo+cAu2WkH7MVFeblRs sPGE4Aifr7/dTQNmR/EhvBLM+EROVAtW+knsKUPD+lMjcjmDC0x9j1NxnpHj89/ySmcN jkPWW4oKXpiUPePtTVSAWD14Ig/3dqkM86dwMonGfKkgsPflJbhf9Is4Acyosqqtc17q qyaQ== X-Gm-Message-State: ANoB5pn6v4OVhIfAx8mYWpfj/GrMmxxvz4BDBp2m7yANHl2vin76wzfG mUsoNWflcrMrmfkwWYTGf4bnV4HzYFc0KUYg7efn2C7iLItNOVKVk5vXVryQT6nnlGBFCj28XY0 790hfzB5YtR5yKDk3rIqFhXa9 X-Received: by 2002:a5d:5f04:0:b0:241:e9a6:fb3 with SMTP id cl4-20020a5d5f04000000b00241e9a60fb3mr22408086wrb.462.1669808919571; Wed, 30 Nov 2022 03:48:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf71i1QvnhhrXaTwa+I+8EpX/qnDqrYR4GbrQTWzEGi7bUvVncNy/xc2a74B4erNgTJKDcQn3Q== X-Received: by 2002:a5d:5f04:0:b0:241:e9a6:fb3 with SMTP id cl4-20020a5d5f04000000b00241e9a60fb3mr22408062wrb.462.1669808919318; Wed, 30 Nov 2022 03:48:39 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id 16-20020a05600c22d000b003b497138093sm1620841wmg.47.2022.11.30.03.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 03:48:38 -0800 (PST) Date: Wed, 30 Nov 2022 12:48:35 +0100 From: Guillaume Nault To: Christoph Hellwig Cc: Benjamin Coddington , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Reisner , Lars Ellenberg , Christoph =?iso-8859-1?Q?B=F6hmwalder?= , Jens Axboe , Josef Bacik , Keith Busch , Sagi Grimberg , Lee Duncan , Chris Leech , Mike Christie , "James E.J. Bottomley" , "Martin K. Petersen" , Valentina Manea , Shuah Khan , Greg Kroah-Hartman , David Howells , Marc Dionne , Steve French , Christine Caulfield , David Teigland , Mark Fasheh , Joel Becker , Joseph Qi , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ilya Dryomov , Xiubo Li , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, nbd@other.debian.org, linux-nvme@lists.infradead.org, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag Message-ID: <20221130114835.GA29316@pc-4.home> References: <20221129140242.GA15747@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129140242.GA15747@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 29, 2022 at 03:02:42PM +0100, Christoph Hellwig wrote: > Hmm. Having to set a flag to not accidentally corrupt per-task > state seems a bit fragile. Wouldn't it make sense to find a way to opt > into the feature only for sockets created from the syscall layer? That's something I originally considered. But, as far as I can see, nbd needs this flag _and_ uses sockets created in user space. So it'd still need to opt out manually.