From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D326AC433FE for ; Wed, 30 Nov 2022 18:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbiK3S3h (ORCPT ); Wed, 30 Nov 2022 13:29:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbiK3S31 (ORCPT ); Wed, 30 Nov 2022 13:29:27 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0FA28BD11; Wed, 30 Nov 2022 10:29:26 -0800 (PST) Received: from fraeml714-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4NMnhr5VFgz6HJPl; Thu, 1 Dec 2022 02:26:20 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml714-chm.china.huawei.com (10.206.15.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 30 Nov 2022 19:29:24 +0100 Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 18:29:24 +0000 Date: Wed, 30 Nov 2022 18:29:23 +0000 From: Jonathan Cameron To: Olivier Moysan CC: Jonathan Cameron , Lars-Peter Clausen , Maxime Coquelin , Alexandre Torgue , , , , Subject: Re: [PATCH] iio: adc: stm32-dfsdm: fill module aliases Message-ID: <20221130182923.00006695@Huawei.com> In-Reply-To: <20221130160904.77617-1-olivier.moysan@foss.st.com> References: <20221130160904.77617-1-olivier.moysan@foss.st.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Nov 2022 17:09:04 +0100 Olivier Moysan wrote: > When STM32 DFSDM driver is built as module, no modalias information > is available. This prevents module to be loaded by udev. > Add MODULE_DEVICE_TABLE() to fill module aliases. > > Signed-off-by: Olivier Moysan These are always a bit marginal on whether they are a 'fix' or not, but given we want them backported, a fixes tag probably makes sense. J > --- > drivers/iio/adc/stm32-dfsdm-adc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index 6d21ea84fa82..a428bdb567d5 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -1520,6 +1520,7 @@ static const struct of_device_id stm32_dfsdm_adc_match[] = { > }, > {} > }; > +MODULE_DEVICE_TABLE(of, stm32_dfsdm_adc_match); > > static int stm32_dfsdm_adc_probe(struct platform_device *pdev) > {