From: Kees Cook <keescook@chromium.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
KP Singh <kpsingh@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Florent Revest <revest@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@infradead.org>, Chris Mason <clm@meta.com>
Subject: Re: [RFC PATCH] panic: Add new taint flag for fault injection
Date: Thu, 1 Dec 2022 08:53:02 -0800 [thread overview]
Message-ID: <202212010852.6D4B542@keescook> (raw)
In-Reply-To: <20221201114848.13a87aca@gandalf.local.home>
On Thu, Dec 01, 2022 at 11:48:48AM -0500, Steven Rostedt wrote:
> On Thu, 1 Dec 2022 08:39:28 -0800
> Kees Cook <keescook@chromium.org> wrote:
>
> > On Fri, Dec 02, 2022 at 01:37:13AM +0900, Masami Hiramatsu (Google) wrote:
> > > From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > >
> > > Since the function error injection framework in the fault injection
> > > subsystem can change the function code flow forcibly, it may cause
> > > unexpected behavior (but that is the purpose of this feature).
> > > To identify this in the kernel oops message, add a new taint flag
> > > for this, and set it if it is (and similar things in BPF) used.
> >
> > Why is hooking through BPF considered to be "fault injection" here?
> >
>
> Have you not been reading this thread?
I skimmed it -- trying to catch up from turkey week. If this was already
covered, then please ignore me. It just wasn't obvious from the commit
log why it was included.
--
Kees Cook
next prev parent reply other threads:[~2022-12-01 16:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 15:44 [PATCH] error-injection: Add prompt for function error injection Steven Rostedt
2022-11-21 19:32 ` Borislav Petkov
2022-11-21 23:36 ` Alexei Starovoitov
2022-11-22 0:09 ` Masami Hiramatsu
2022-11-22 0:24 ` Steven Rostedt
2022-11-22 0:40 ` Steven Rostedt
2022-11-22 10:39 ` Borislav Petkov
2022-11-22 17:42 ` Chris Mason
2022-11-22 18:16 ` Borislav Petkov
2022-11-22 18:29 ` Steven Rostedt
2022-11-22 19:51 ` Chris Mason
2022-11-30 22:37 ` Andrew Morton
2022-12-01 16:58 ` Alexei Starovoitov
2022-12-01 17:39 ` Benjamin Tissoires
2022-12-01 21:12 ` Andrew Morton
2022-12-01 21:13 ` Linus Torvalds
2022-12-02 0:46 ` Jiri Kosina
2022-12-02 0:57 ` Linus Torvalds
2022-12-02 1:03 ` Jiri Kosina
2022-12-02 1:32 ` Steven Rostedt
2022-12-02 1:41 ` Alexei Starovoitov
2022-12-02 15:56 ` Theodore Ts'o
2022-12-02 21:27 ` Alexei Starovoitov
2022-12-02 23:17 ` Steven Rostedt
2022-12-03 0:55 ` Alexei Starovoitov
2022-12-04 22:50 ` Masami Hiramatsu
2022-12-06 2:05 ` Alexei Starovoitov
2022-12-02 14:55 ` Benjamin Tissoires
2022-12-02 19:30 ` Alexei Starovoitov
2022-12-05 17:01 ` Benjamin Tissoires
2022-12-01 14:41 ` Masami Hiramatsu
2022-12-01 16:37 ` [RFC PATCH] panic: Add new taint flag for fault injection Masami Hiramatsu (Google)
2022-12-01 16:39 ` Kees Cook
2022-12-01 16:48 ` Steven Rostedt
2022-12-01 16:53 ` Kees Cook [this message]
2022-12-01 19:14 ` Steven Rostedt
2022-12-01 21:00 ` Chris Mason
2022-12-01 21:18 ` Linus Torvalds
2022-12-02 6:17 ` Christoph Hellwig
2022-12-01 21:25 ` Steven Rostedt
2022-12-01 21:29 ` Steven Rostedt
2022-12-02 0:46 ` Masami Hiramatsu
2022-12-01 16:40 ` Steven Rostedt
2022-11-21 22:24 ` [PATCH] error-injection: Add prompt for function error injection Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202212010852.6D4B542@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bp@alien8.de \
--cc=clm@meta.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox