Re: [PATCH v8 1/3] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer

Prashant Malani
2022-12-01T21:45:37Z

Sorry, one other thing:

On Thu, Dec 1, 2022 at 1:12 PM Prashant Malani <pmalani@chromium.org> wrote:
>
> Hi,
>
> On Wed, Nov 30, 2022 at 12:13 PM Mark Hasemeyer <markhas@chromium.org> wrote:
> >
> > This patch does following:
> > 1. Adds a new cros-ec-uart driver. This driver can send EC requests on
> > UART and process response packets received on UART transport.
> > 2. Once probed, this driver will initialize the serdev device based on
> > the underlying information in the ACPI resource. After serdev device
> > properties are set, this driver will register itself cros-ec.
> > 3. High level driver can use this implementation to talk to ChromeOS
> > Embedded Controller device in case it supports UART as transport.
> > 4. When cros-ec driver initiates a request packet, outgoing message is
> > processed in buffer and sent via serdev. Once bytes are sent, driver
> > enables a wait_queue.
> > 5. Since ChromeOS EC device sends response asynchronously, AP's TTY
> > driver accumulates response bytes and calls the registered callback.
> > TTY driver can send multiple callback for bytes ranging from 1 to MAX
> > bytes supported by EC device.
> > 6. Driver waits for EC_MSG_DEADLINE_MS to collect and process received
> > bytes. It wakes wait_queue if expected bytes are received or else
> > wait_queue timeout. Based on the error condition, driver returns
> > data_len or error to cros_ec.
> >
> > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> > Signed-off-by: Mark Hasemeyer <markhas@chromium.org>

It is not clear who is the author of this patch. I'm guessing it is
Mark Hasemayer, since
they're the sender, but in that case their Signed-off-by tag should be
first [4].
If it is Bhanu Prakash Maiya, then the git commit should list them as
the author.

Also note that for patches which are developed by > 1 person,
Co-developed-by is an option
to share attribution.

> [1] https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144
> [3] https://elixir.bootlin.com/linux/v6.1-rc7/source/include/linux/wait.h#L510
[4] https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=signed%20off#sign-your-work-the-developer-s-certificate-of-origin