Re: [PATCH v8 1/3] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer

Mark Hasemeyer
2022-12-02T04:53:24Z

> + /* Received bytes are more the allocated buffer*/
> + ec_uart->response.error = -EMSGSIZE;
> +
> + /* Wake the calling thread */
> + wake_up_interruptible(&ec_uart->response.wait_queue);

I believe the "received" conditional variable should be set before calling
wake_up_interruptible. Otherwise the calling thread will not be (immediately)
awakened as the condition is still false. Currently, the calling thread will
wait until it times out in this case.