From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@somainline.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Vinod Koul" <vkoul@kernel.org>, "Alex Elder" <elder@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-serial@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH v5 12/14] tty: serial: qcom-geni-serial: stop operations in progress at shutdown
Date: Fri, 2 Dec 2022 09:55:52 +0100 [thread overview]
Message-ID: <20221202085554.59637-13-brgl@bgdev.pl> (raw)
In-Reply-To: <20221202085554.59637-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
We don't stop transmissions in progress at shutdown. This is fine with
FIFO SE mode but with DMA it causes trouble so fix it now.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/tty/serial/qcom_geni_serial.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 808b0250d51e..1dfc0122ff53 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -864,6 +864,8 @@ static void get_tx_fifo_size(struct qcom_geni_serial_port *port)
static void qcom_geni_serial_shutdown(struct uart_port *uport)
{
disable_irq(uport->irq);
+ qcom_geni_serial_stop_tx(uport);
+ qcom_geni_serial_stop_rx(uport);
}
static int qcom_geni_serial_port_setup(struct uart_port *uport)
--
2.37.2
next prev parent reply other threads:[~2022-12-02 8:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 8:55 [PATCH v5 00/14] serial: qcom-geni-serial: implement support for SE DMA Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 01/14] tty: serial: qcom-geni-serial: drop unneeded forward definitions Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 02/14] tty: serial: qcom-geni-serial: remove unused symbols Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 03/14] tty: serial: qcom-geni-serial: align #define values Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 04/14] tty: serial: qcom-geni-serial: improve the to_dev_port() macro Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 05/14] tty: serial: qcom-geni-serial: remove stray newlines Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 06/14] tty: serial: qcom-geni-serial: refactor qcom_geni_serial_isr() Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 07/14] tty: serial: qcom-geni-serial: remove unneeded tabs Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 08/14] tty: serial: qcom-geni-serial: split out the FIFO tx code Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 09/14] tty: serial: qcom-geni-serial: refactor qcom_geni_serial_send_chunk_fifo() Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 10/14] tty: serial: qcom-geni-serial: drop the return value from handle_rx Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 11/14] tty: serial: qcom-geni-serial: use of_device_id data Bartosz Golaszewski
2022-12-02 8:55 ` Bartosz Golaszewski [this message]
2022-12-20 13:14 ` [PATCH v5 12/14] tty: serial: qcom-geni-serial: stop operations in progress at shutdown Krzysztof Kozlowski
2022-12-02 8:55 ` [PATCH v5 13/14] soc: qcom-geni-se: add more symbol definitions Bartosz Golaszewski
2022-12-02 8:55 ` [PATCH v5 14/14] tty: serial: qcom-geni-serial: add support for serial engine DMA Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202085554.59637-13-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox