From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB551C47088 for ; Fri, 2 Dec 2022 23:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234550AbiLBXFF (ORCPT ); Fri, 2 Dec 2022 18:05:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233742AbiLBXEz (ORCPT ); Fri, 2 Dec 2022 18:04:55 -0500 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D687DB0F4 for ; Fri, 2 Dec 2022 15:04:51 -0800 (PST) Received: by mail-pg1-x52f.google.com with SMTP id q1so5528924pgl.11 for ; Fri, 02 Dec 2022 15:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=3eWdYeAABAMnoEoSZbvIqfAvjGuNN+NLL8O7DVcc5tw=; b=LPDjcXKRkJF0ChWSvwqdMs4z+WaNIJwO0yY5Q59nGeM3pDMHVwIb6cPYLQgWVJguAB ciAtCM4G0YFdDjeGOSSxDSrCrEHGWnroQqTT/uQy4yjM39FpLTUwFW+H4Sr88a8juay4 4lauU6rk4+hFPwNW6zqanjTHmoMbiFkIJBgIM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3eWdYeAABAMnoEoSZbvIqfAvjGuNN+NLL8O7DVcc5tw=; b=ORu8OSOl2KEJlgvv951sqyjQULCsnLZLPAETQ0zQRdQb/VobJsLAn/VN9gmHOQocrr kafilLmVk7kPZgqkI7OpwBAl5a9V7+gaWstdM/nA69Szlg+rf/j/qGn0EHLPk7uJH1YD TWOeS7td6uErKnGKrCp5D2oU24v7C0KeYSCx1UU7Z4kPnS5QKaFWnjea2mldmUOa/pz+ 0ZKwR8u8PYEi112CNZC2Z6p1GYXuhHEUmahldn9HMHv3NHEjD9sAvQ8qYxhOHBZ1ExZP vDw6BlkyLHDEzreMfxtmpm/nrokkPUsMgDsD0rWtnhAP9AfXFxQcpPdLVZJXb48NbdgF W5gw== X-Gm-Message-State: ANoB5ploXM4HWD+G7DnaittEDCCw9msRTuv+j3BcNnglNGhE1VPbK/SQ fNOOp+UXwIWjWuwptNcllqA3sA== X-Google-Smtp-Source: AA0mqf6wCldb+aTkXQCqBjXUJrvffCgFhxrhyXTrWtI0GxUZ1d4eeeVzDPxJ8FdEPH3kPGZuS+RPDw== X-Received: by 2002:a63:e34b:0:b0:477:de0a:3233 with SMTP id o11-20020a63e34b000000b00477de0a3233mr34109179pgj.467.1670022291026; Fri, 02 Dec 2022 15:04:51 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c3-20020a17090a4d0300b00218998eb828sm7058622pjg.45.2022.12.02.15.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 15:04:50 -0800 (PST) Date: Fri, 2 Dec 2022 15:04:49 -0800 From: Kees Cook To: Ryder Lee Cc: Bo Jiao =?utf-8?B?KOeEpuazoik=?= , MeiChia Chiu =?utf-8?B?KOmCsee+juWYiSk=?= , "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "gustavo@embeddedor.com" , "linux-hardening@vger.kernel.org" , Shayne Chen =?utf-8?B?KOmZs+i7kuS4nik=?= , "nbd@nbd.name" , "lorenzo@kernel.org" , "kuba@kernel.org" , Sean Wang , "kvalo@kernel.org" , "edumazet@google.com" , Sujuan Chen =?utf-8?B?KOmZiOe0oOWonyk=?= , "pabeni@redhat.com" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-next@vger.kernel.org" , "matthias.bgg@gmail.com" , "davem@davemloft.net" , "linux-wireless@vger.kernel.org" Subject: Re: Coverity: mt7915_mcu_get_chan_mib_info(): Memory - illegal accesses Message-ID: <202212021504.A1942911@keescook> References: <202212021424.34C0F695E4@keescook> <1a16599dd5e4eed86bae112a232a3599af43a5f2.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1a16599dd5e4eed86bae112a232a3599af43a5f2.camel@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 02, 2022 at 10:56:19PM +0000, Ryder Lee wrote: > On Fri, 2022-12-02 at 14:24 -0800, coverity-bot wrote: > > Hello! > > > > This is an experimental semi-automated report about issues detected > > by > > Coverity from a scan of next-20221202 as part of the linux-next scan > > project: > > > https://urldefense.com/v3/__https://scan.coverity.com/projects/linux-next-weekly-scan__;!!CTRNKA9wMg0ARbw!j7j_C0KpO4VD2yMOodvpeIexTGq4fhy2yq6nokNua9u4LToiUOLk4ou8JFFNrXkrh80d5BK2k44faRQstHE9$  > > > > > > You're getting this email because you were associated with the > > identified > > lines of code (noted below) that were touched by commits: > > > > Thu Feb 3 13:57:56 2022 +0100 > > 417a4534d223 ("mt76: mt7915: update mt7915_chan_mib_offs for > > mt7916") > > > > Coverity reported the following: > > > > *** CID 1527801: Memory - illegal accesses (OVERRUN) > > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:3005 in > > mt7915_mcu_get_chan_mib_info() > > 2999 start = 5; > > 3000 ofs = 0; > > 3001 } > > 3002 > > 3003 for (i = 0; i < 5; i++) { > > 3004 req[i].band = cpu_to_le32(phy->mt76->band_idx); > > vvv CID 1527801: Memory - illegal accesses (OVERRUN) > > vvv Overrunning array "offs" of 9 4-byte elements at element > > index 9 (byte offset 39) using index "i + start" (which evaluates to > > 9). > > 3005 req[i].offs = cpu_to_le32(offs[i + start]); > > 3006 > > 3007 if (!is_mt7915(&dev->mt76) && i == 3) > > 3008 break; > > 3009 } > > 3010 > > > > If this is a false positive, please let us know so we can mark it as > > such, or teach the Coverity rules to be smarter. If not, please make > > sure fixes get into linux-next. :) For patches fixing this, please > > include these lines (but double-check the "Fixes" first): > > > > I think this is a false postive as the subsequent check 'if > (!is_mt7915(&dev->mt76) && i == 3)' should break array "offs" of 8. Ah, okay. What if is_mt7915(&dev->mt76) is always true? -Kees > > Ryder > > > Reported-by: coverity-bot > > Addresses-Coverity-ID: 1527801 ("Memory - illegal accesses") > > Fixes: 417a4534d223 ("mt76: mt7915: update mt7915_chan_mib_offs for > > mt7916") > > > > Thanks for your attention! > > -- Kees Cook