Re: [PATCH v4 05/39] x86/fpu/xstate: Introduce CET MSR and XSAVES supervisor states

Edgecombe, Rick P
2022-12-21T00:46:04Z

On Tue, 2022-12-20 at 12:32 +0100, Borislav Petkov wrote:
> On Fri, Dec 02, 2022 at 04:35:32PM -0800, Rick Edgecombe wrote:
> > @@ -252,6 +254,14 @@ struct pkru_state {
> >         u32                             pad;
> >   } __packed;
> >
> > +/*
> > + * State component 11 is Control-flow Enforcement user states
> > + */
> > +struct cet_user_state {
> > +       u64 user_cet;                   /* user control-flow
> > settings */
> > +       u64 user_ssp;                   /* user shadow stack
> > pointer */
>
> Please put those side comments over the members, like struct fpstate
> does it in that same file.

Sure, thanks.