Re: [RESEND PATCH linux-next v2 00/10] drm: Remove some obsolete drivers(tdfx, mga, i810, savage, r128, sis, via)

Thomas Zimmermann
2023-01-05T13:02:29Z

[-- Attachment #1.1: Type: text/plain, Size: 7838 bytes --]

Hi

Am 05.01.23 um 13:40 schrieb Daniel Vetter:
> On Thu, Dec 08, 2022 at 08:42:07PM +0800, Cai Huoqing wrote:
>> On 03 12月 22 18:22:51, Cai Huoqing wrote:
>>> Commit 399516ab0fee ("MAINTAINERS: Add a bunch of legacy (UMS) DRM drivers")
>>> marked these drivers obsolete 7 years ago.
>>> And the mesa UMD of these drm drivers already in deprecated list
>>> in the link: https://docs.mesa3d.org/systems.html
>>>
>>> 3dfx Glide-->driver/gpu/drm/tdfx
>>> Matrox-->driver/gpu/drm/mga
>>> Intel i810-->driver/gpu/drm/i810
>>> S3 Savage-->drivers/gpu/drm/savage
>>> ATI Rage 128->drivers/gpu/drm/r128
>>> Silicon Integrated Systems->drivers/gpu/drm/sis
>>> VIA Unichrome->drivers/gpu/drm/via
>>>
>>> v1->v2:
>>> 1.Add drm via driver to the patchset.
>>> 2.Remove related drm_pciids.
>>> 3.Remove related drm uapi header files.
>>> 4.split to series avoid large patch email.
>> Just ping these patch series.
>> The v1 comments here,
>> https://lore.kernel.org/lkml/39d8ac1a-d92f-7cdc-14cd-944342f78c1a@suse.de/
>
> Are we really sure that all users of these are gone? Also, I'm not really
> seeing the benefit of this, we've managed to split out the legacy code
> quite well, so carrying around isn't hurting anything afaics?

My first reaction was 'no way'. But then I thought about possible users
of this code and I cannot see anyone relying on it. You'd need an
ancient userspace Mesa library plus the most recent kernel. And all the
rendering is OpenGL 1.x. Are there even Linux programs for that?

So as far as I'm concerned

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

DRM's legacy infrastructure could be kept for a few more releases. Just
in case one of the drivers makes a comeback.

There is code in nouveau that uses legacy functionality for its ancient
userspace. I think we should scrap that as well. (See
NOUVEAU_LEGACY_CTX_SUPPORT.)

Best regards
Thomas

> -Daniel
>
>>
>> Thanks,
>> Cai
>>>
>>> Cai Huoqing (10):
>>> drm: Remove the obsolete driver-i810
>>> drm: Remove the obsolete driver-mga
>>> drm: Remove the obsolete driver-r128
>>> drm: Remove the obsolete driver-savage
>>> drm: Remove the obsolete driver-sis
>>> drm: Remove the obsolete driver-tdfx
>>> drm: Remove the obsolete driver-via
>>> drm: Add comments to Kconfig
>>> drm: Remove some obsolete drm pciids(tdfx, mga, i810, savage, r128,
>>> sis, via)
>>> MAINTAINERS: Remove some obsolete drivers info(tdfx, mga, i810,
>>> savage, r128, sis)
>>>
>>> MAINTAINERS | 29 -
>>> drivers/gpu/drm/Kconfig | 59 +-
>>> drivers/gpu/drm/Makefile | 7 -
>>> drivers/gpu/drm/i810/Makefile | 8 -
>>> drivers/gpu/drm/i810/i810_dma.c | 1266 ---------
>>> drivers/gpu/drm/i810/i810_drv.c | 101 -
>>> drivers/gpu/drm/i810/i810_drv.h | 246 --
>>> drivers/gpu/drm/mga/Makefile | 11 -
>>> drivers/gpu/drm/mga/mga_dma.c | 1168 --------
>>> drivers/gpu/drm/mga/mga_drv.c | 104 -
>>> drivers/gpu/drm/mga/mga_drv.h | 685 -----
>>> drivers/gpu/drm/mga/mga_ioc32.c | 197 --
>>> drivers/gpu/drm/mga/mga_irq.c | 169 --
>>> drivers/gpu/drm/mga/mga_state.c | 1099 --------
>>> drivers/gpu/drm/mga/mga_warp.c | 167 --
>>> drivers/gpu/drm/r128/Makefile | 10 -
>>> drivers/gpu/drm/r128/ati_pcigart.c | 228 --
>>> drivers/gpu/drm/r128/ati_pcigart.h | 31 -
>>> drivers/gpu/drm/r128/r128_cce.c | 944 -------
>>> drivers/gpu/drm/r128/r128_drv.c | 116 -
>>> drivers/gpu/drm/r128/r128_drv.h | 544 ----
>>> drivers/gpu/drm/r128/r128_ioc32.c | 199 --
>>> drivers/gpu/drm/r128/r128_irq.c | 118 -
>>> drivers/gpu/drm/r128/r128_state.c | 1641 -----------
>>> drivers/gpu/drm/savage/Makefile | 9 -
>>> drivers/gpu/drm/savage/savage_bci.c | 1082 --------
>>> drivers/gpu/drm/savage/savage_drv.c | 91 -
>>> drivers/gpu/drm/savage/savage_drv.h | 580 ----
>>> drivers/gpu/drm/savage/savage_state.c | 1169 --------
>>> drivers/gpu/drm/sis/Makefile | 10 -
>>> drivers/gpu/drm/sis/sis_drv.c | 143 -
>>> drivers/gpu/drm/sis/sis_drv.h | 80 -
>>> drivers/gpu/drm/sis/sis_mm.c | 363 ---
>>> drivers/gpu/drm/tdfx/Makefile | 8 -
>>> drivers/gpu/drm/tdfx/tdfx_drv.c | 90 -
>>> drivers/gpu/drm/tdfx/tdfx_drv.h | 47 -
>>> drivers/gpu/drm/via/Makefile | 8 -
>>> drivers/gpu/drm/via/via_3d_reg.h | 1771 ------------
>>> drivers/gpu/drm/via/via_dri1.c | 3630 -------------------------
>>> include/drm/drm_pciids.h | 112 -
>>> include/uapi/drm/i810_drm.h | 292 --
>>> include/uapi/drm/mga_drm.h | 429 ---
>>> include/uapi/drm/r128_drm.h | 336 ---
>>> include/uapi/drm/savage_drm.h | 220 --
>>> include/uapi/drm/sis_drm.h | 77 -
>>> include/uapi/drm/via_drm.h | 282 --
>>> 46 files changed, 1 insertion(+), 19975 deletions(-)
>>> delete mode 100644 drivers/gpu/drm/i810/Makefile
>>> delete mode 100644 drivers/gpu/drm/i810/i810_dma.c
>>> delete mode 100644 drivers/gpu/drm/i810/i810_drv.c
>>> delete mode 100644 drivers/gpu/drm/i810/i810_drv.h
>>> delete mode 100644 drivers/gpu/drm/mga/Makefile
>>> delete mode 100644 drivers/gpu/drm/mga/mga_dma.c
>>> delete mode 100644 drivers/gpu/drm/mga/mga_drv.c
>>> delete mode 100644 drivers/gpu/drm/mga/mga_drv.h
>>> delete mode 100644 drivers/gpu/drm/mga/mga_ioc32.c
>>> delete mode 100644 drivers/gpu/drm/mga/mga_irq.c
>>> delete mode 100644 drivers/gpu/drm/mga/mga_state.c
>>> delete mode 100644 drivers/gpu/drm/mga/mga_warp.c
>>> delete mode 100644 drivers/gpu/drm/r128/Makefile
>>> delete mode 100644 drivers/gpu/drm/r128/ati_pcigart.c
>>> delete mode 100644 drivers/gpu/drm/r128/ati_pcigart.h
>>> delete mode 100644 drivers/gpu/drm/r128/r128_cce.c
>>> delete mode 100644 drivers/gpu/drm/r128/r128_drv.c
>>> delete mode 100644 drivers/gpu/drm/r128/r128_drv.h
>>> delete mode 100644 drivers/gpu/drm/r128/r128_ioc32.c
>>> delete mode 100644 drivers/gpu/drm/r128/r128_irq.c
>>> delete mode 100644 drivers/gpu/drm/r128/r128_state.c
>>> delete mode 100644 drivers/gpu/drm/savage/Makefile
>>> delete mode 100644 drivers/gpu/drm/savage/savage_bci.c
>>> delete mode 100644 drivers/gpu/drm/savage/savage_drv.c
>>> delete mode 100644 drivers/gpu/drm/savage/savage_drv.h
>>> delete mode 100644 drivers/gpu/drm/savage/savage_state.c
>>> delete mode 100644 drivers/gpu/drm/sis/Makefile
>>> delete mode 100644 drivers/gpu/drm/sis/sis_drv.c
>>> delete mode 100644 drivers/gpu/drm/sis/sis_drv.h
>>> delete mode 100644 drivers/gpu/drm/sis/sis_mm.c
>>> delete mode 100644 drivers/gpu/drm/tdfx/Makefile
>>> delete mode 100644 drivers/gpu/drm/tdfx/tdfx_drv.c
>>> delete mode 100644 drivers/gpu/drm/tdfx/tdfx_drv.h
>>> delete mode 100644 drivers/gpu/drm/via/Makefile
>>> delete mode 100644 drivers/gpu/drm/via/via_3d_reg.h
>>> delete mode 100644 drivers/gpu/drm/via/via_dri1.c
>>> delete mode 100644 include/uapi/drm/i810_drm.h
>>> delete mode 100644 include/uapi/drm/mga_drm.h
>>> delete mode 100644 include/uapi/drm/r128_drm.h
>>> delete mode 100644 include/uapi/drm/savage_drm.h
>>> delete mode 100644 include/uapi/drm/sis_drm.h
>>> delete mode 100644 include/uapi/drm/via_drm.h
>>>
>>> --
>>> 2.25.1
>>>
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]