From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA4B2C4321E for ; Sun, 4 Dec 2022 17:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230216AbiLDRfh (ORCPT ); Sun, 4 Dec 2022 12:35:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229938AbiLDRff (ORCPT ); Sun, 4 Dec 2022 12:35:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97FC364F4 for ; Sun, 4 Dec 2022 09:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670175280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6aqkEPzvoF2u3Z2AprW+w5Z1b+DAYD9ZKPIwacVPQlM=; b=Rc7LSwXOTpXwDjzdZC5w2GhkZcazJGFTqq0edkZbn7VUa7FHNAUzf3eWKq+qI6lmdBGai/ 10MYSEBR5FwkN3ZgzgkKeamd2zyTXj1yapAIu0b1t3l5yWHVX6iLEbm7p5ecC2uFzynZ3R l0zXw59+crSGuKgmAepEn4dt8PJAdBI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-510-hlymyj5AMBmZ09uF0YdseQ-1; Sun, 04 Dec 2022 12:34:39 -0500 X-MC-Unique: hlymyj5AMBmZ09uF0YdseQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 08286800159; Sun, 4 Dec 2022 17:34:39 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (ovpn-192-89.brq.redhat.com [10.40.192.89]) by smtp.corp.redhat.com (Postfix) with SMTP id 2B095140EBF3; Sun, 4 Dec 2022 17:34:36 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 4 Dec 2022 18:34:38 +0100 (CET) Date: Sun, 4 Dec 2022 18:34:36 +0100 From: Oleg Nesterov To: Thomas Gleixner Cc: Andrew Morton , Masami Hiramatsu , Denys Vlasenko , Seiji Nishikawa , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] uprobes/x86: allow to probe a "nop" insn with 0x66 prefix Message-ID: <20221204173435.GA8707@redhat.com> References: <20221201142644.GA27185@redhat.com> <871qpiqaz3.ffs@tglx> <20221202125401.GA16230@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221202125401.GA16230@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/02, Oleg Nesterov wrote: > > On 12/02, Thomas Gleixner wrote: > > > > On Thu, Dec 01 2022 at 15:26, Oleg Nesterov wrote: > > > > > From: Denys Vlasenko > > > > > > Intel icc -hotpatch inserts 2-byte "0x66 0x90" NOP at the start of each > > > function to reserve extra space for hot-patching, and currently it is not > > > possible to probe these functions because branch_setup_xol_ops() wrongly > > > nacks NOP with REP prefix. > > > > > > Fixes: 250bbd12c2fe ("uprobes/x86: Refuse to attach uprobe to "word-sized" branch insns") > > > Reported-by: Seiji Nishikawa > > > Signed-off-by: Oleg Nesterov > > > > The SOB chain is invalid as it lacks the author's signoff. > > Denys, can we have your signed-off-by? OK, let me turn "From" into "Suggested-by" if this can help to merge this fix. After all, the patch is really simple, I don't think Denys will object when he returns. I am sending v2 with Masami's ack applied. Oleg.