From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6499EC4321E for ; Mon, 5 Dec 2022 02:39:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231296AbiLECjj (ORCPT ); Sun, 4 Dec 2022 21:39:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230479AbiLECjh (ORCPT ); Sun, 4 Dec 2022 21:39:37 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55572FCC4 for ; Sun, 4 Dec 2022 18:39:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E329860EF7 for ; Mon, 5 Dec 2022 02:39:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7AD4C433C1; Mon, 5 Dec 2022 02:39:34 +0000 (UTC) Date: Sun, 4 Dec 2022 21:39:29 -0500 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: kernel test robot , David Howells , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] trace: Fix some checker warnings Message-ID: <20221204213929.2edc730b@rorschach.local.home> In-Reply-To: <20221205112236.f99c6104e988aa4f3dd89cd0@kernel.org> References: <166992525941.1716618.13740663757583361463.stgit@warthog.procyon.org.uk> <202212022034.OqPXTS9u-lkp@intel.com> <20221205112236.f99c6104e988aa4f3dd89cd0@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Dec 2022 11:22:36 +0900 Masami Hiramatsu (Google) wrote: > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index 5cfc95a52bc3..14f18edfe5bc 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -6572,7 +6572,8 @@ tracing_thresh_write(struct file *filp, const char __user *ubuf, > return ret; > } > > -#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) > +#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \ > + || defined(CONFIG_OSNOISE_TRACER) > When it gets this much, we need to put it into the trace.h header and define it. Actually, we have something that handles this too. #if (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \ || defined(CONFIG_OSNOISE_TRACER)) && defined(CONFIG_FSNOTIFY) #define LATENCY_FS_NOTIFY #endif We can add: #if (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \ || defined(CONFIG_OSNOISE_TRACER)) && defined(CONFIG_FSNOTIFY) #define LATENCY_FS_NOTIFY +#define USES_MAX_TRACE #endif And use that instead. -- Steve