From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB96C4321E for ; Mon, 5 Dec 2022 03:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbiLED3a (ORCPT ); Sun, 4 Dec 2022 22:29:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230307AbiLED31 (ORCPT ); Sun, 4 Dec 2022 22:29:27 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96DD412A90 for ; Sun, 4 Dec 2022 19:29:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3036060F56 for ; Mon, 5 Dec 2022 03:29:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7D80C433D6; Mon, 5 Dec 2022 03:29:24 +0000 (UTC) Date: Sun, 4 Dec 2022 22:29:21 -0500 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: kernel test robot , David Howells , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] trace: Fix some checker warnings Message-ID: <20221204222921.047fcf4b@rorschach.local.home> In-Reply-To: <20221205121119.537fa922bbd8147b9df5ae6c@kernel.org> References: <166992525941.1716618.13740663757583361463.stgit@warthog.procyon.org.uk> <202212022034.OqPXTS9u-lkp@intel.com> <20221205112236.f99c6104e988aa4f3dd89cd0@kernel.org> <20221204213929.2edc730b@rorschach.local.home> <20221205121119.537fa922bbd8147b9df5ae6c@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Dec 2022 12:11:19 +0900 Masami Hiramatsu (Google) wrote: > > #if (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \ > > || defined(CONFIG_OSNOISE_TRACER)) && defined(CONFIG_FSNOTIFY) > > #define LATENCY_FS_NOTIFY > > +#define USES_MAX_TRACE > > #endif > > > > And use that instead. > > BTW, why can't HWLAT_TRACER and OSNOISE_TRACER depend on TRACER_MAX_TRACE? > I think it is better to reduce combinations of those, especially partially > enabling a feature seems a bit dangerous. Well, the issue with that is that if the TRACER_MAX_TRACE is off (because it's not something commonly selected), it will hide osnoise and hwlat from showing up in the menus. -- Steve