* [PATCH] dt-bindings: PCI: qcom: Allow 'dma-coherent' property
@ 2022-12-05 9:45 Johan Hovold
2022-12-05 22:25 ` Rob Herring
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Johan Hovold @ 2022-12-05 9:45 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Bjorn Helgaas,
Rob Herring, Krzysztof Wilczyński, Krzysztof Kozlowski,
linux-arm-msm, linux-pci, devicetree, linux-kernel, Johan Hovold
Devices on some PCIe buses may be cache coherent and must be marked as
such in the devicetree to avoid data corruption.
This is specifically needed on recent Qualcomm platforms like SC8280XP.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
Lorenzo, the corresponding SC8280XP DT fix is heading for 6.2 so it
would be nice if this one could be merged for 6.2-rc1 (or -rc2) as well
to avoid the corresponding DT validation warnings.
Johan
Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 2f851c804bb0..a5859bb3dc28 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -62,6 +62,8 @@ properties:
minItems: 3
maxItems: 13
+ dma-coherent: true
+
interconnects:
maxItems: 2
--
2.37.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: PCI: qcom: Allow 'dma-coherent' property
2022-12-05 9:45 [PATCH] dt-bindings: PCI: qcom: Allow 'dma-coherent' property Johan Hovold
@ 2022-12-05 22:25 ` Rob Herring
2022-12-06 10:56 ` Lorenzo Pieralisi
2022-12-06 12:19 ` Lorenzo Pieralisi
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-12-05 22:25 UTC (permalink / raw)
To: Johan Hovold
Cc: linux-pci, Krzysztof Kozlowski, Konrad Dybcio,
Krzysztof Wilczyński, Bjorn Helgaas, Andy Gross,
Bjorn Andersson, devicetree, linux-arm-msm, linux-kernel,
Lorenzo Pieralisi
On Mon, 05 Dec 2022 10:45:30 +0100, Johan Hovold wrote:
> Devices on some PCIe buses may be cache coherent and must be marked as
> such in the devicetree to avoid data corruption.
>
> This is specifically needed on recent Qualcomm platforms like SC8280XP.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>
> Lorenzo, the corresponding SC8280XP DT fix is heading for 6.2 so it
> would be nice if this one could be merged for 6.2-rc1 (or -rc2) as well
> to avoid the corresponding DT validation warnings.
>
> Johan
>
>
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: PCI: qcom: Allow 'dma-coherent' property
2022-12-05 9:45 [PATCH] dt-bindings: PCI: qcom: Allow 'dma-coherent' property Johan Hovold
2022-12-05 22:25 ` Rob Herring
@ 2022-12-06 10:56 ` Lorenzo Pieralisi
2022-12-06 11:51 ` Johan Hovold
2022-12-06 12:19 ` Lorenzo Pieralisi
2 siblings, 1 reply; 5+ messages in thread
From: Lorenzo Pieralisi @ 2022-12-06 10:56 UTC (permalink / raw)
To: Johan Hovold
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Bjorn Helgaas,
Rob Herring, Krzysztof Wilczyński, Krzysztof Kozlowski,
linux-arm-msm, linux-pci, devicetree, linux-kernel
On Mon, Dec 05, 2022 at 10:45:30AM +0100, Johan Hovold wrote:
> Devices on some PCIe buses may be cache coherent and must be marked as
> such in the devicetree to avoid data corruption.
>
> This is specifically needed on recent Qualcomm platforms like SC8280XP.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>
> Lorenzo, the corresponding SC8280XP DT fix is heading for 6.2 so it
> would be nice if this one could be merged for 6.2-rc1 (or -rc2) as well
> to avoid the corresponding DT validation warnings.
What's the commit base for this patch ? I tried applying to my pci/dt
branch to no avail, please let me know and I will merge it.
Lorenzo
>
> Johan
>
>
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 2f851c804bb0..a5859bb3dc28 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -62,6 +62,8 @@ properties:
> minItems: 3
> maxItems: 13
>
> + dma-coherent: true
> +
> interconnects:
> maxItems: 2
>
> --
> 2.37.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: PCI: qcom: Allow 'dma-coherent' property
2022-12-06 10:56 ` Lorenzo Pieralisi
@ 2022-12-06 11:51 ` Johan Hovold
0 siblings, 0 replies; 5+ messages in thread
From: Johan Hovold @ 2022-12-06 11:51 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Johan Hovold, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Bjorn Helgaas, Rob Herring, Krzysztof Wilczyński,
Krzysztof Kozlowski, linux-arm-msm, linux-pci, devicetree,
linux-kernel
On Tue, Dec 06, 2022 at 11:56:34AM +0100, Lorenzo Pieralisi wrote:
> On Mon, Dec 05, 2022 at 10:45:30AM +0100, Johan Hovold wrote:
> > Devices on some PCIe buses may be cache coherent and must be marked as
> > such in the devicetree to avoid data corruption.
> >
> > This is specifically needed on recent Qualcomm platforms like SC8280XP.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> >
> > Lorenzo, the corresponding SC8280XP DT fix is heading for 6.2 so it
> > would be nice if this one could be merged for 6.2-rc1 (or -rc2) as well
> > to avoid the corresponding DT validation warnings.
>
> What's the commit base for this patch ? I tried applying to my pci/dt
> branch to no avail, please let me know and I will merge it.
That should be pci/qcom which has 3a936b2a5a58 ("dt-bindings: PCI: qcom:
Add SC8280XP/SA8540P interconnects").
Johan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: PCI: qcom: Allow 'dma-coherent' property
2022-12-05 9:45 [PATCH] dt-bindings: PCI: qcom: Allow 'dma-coherent' property Johan Hovold
2022-12-05 22:25 ` Rob Herring
2022-12-06 10:56 ` Lorenzo Pieralisi
@ 2022-12-06 12:19 ` Lorenzo Pieralisi
2 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Pieralisi @ 2022-12-06 12:19 UTC (permalink / raw)
To: Johan Hovold
Cc: Lorenzo Pieralisi, linux-pci, Krzysztof Kozlowski, Konrad Dybcio,
Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, devicetree,
Andy Gross, Bjorn Andersson, linux-arm-msm, linux-kernel
On Mon, 5 Dec 2022 10:45:30 +0100, Johan Hovold wrote:
> Devices on some PCIe buses may be cache coherent and must be marked as
> such in the devicetree to avoid data corruption.
>
> This is specifically needed on recent Qualcomm platforms like SC8280XP.
>
>
Applied to pci/qcom, thanks!
[1/1] dt-bindings: PCI: qcom: Allow 'dma-coherent' property
https://git.kernel.org/lpieralisi/pci/c/74eac50391ce
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-06 12:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-05 9:45 [PATCH] dt-bindings: PCI: qcom: Allow 'dma-coherent' property Johan Hovold
2022-12-05 22:25 ` Rob Herring
2022-12-06 10:56 ` Lorenzo Pieralisi
2022-12-06 11:51 ` Johan Hovold
2022-12-06 12:19 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox