public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Russ Weight <russell.h.weight@intel.com>
Subject: [PATCH v2 4/4] firmware_loader: fix up to_fw_sysfs() to preserve const
Date: Mon,  5 Dec 2022 13:12:06 +0100	[thread overview]
Message-ID: <20221205121206.166576-4-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20221205121206.166576-1-gregkh@linuxfoundation.org>

to_fw_sysfs() was changed in commit 23680f0b7d7f ("driver core: make
struct class.dev_uevent() take a const *") to pass in a const pointer
but not pass it back out to handle some changes in the driver core.
That isn't the best idea as it could cause problems if used incorrectly,
so switch to use the container_of_const() macro instead which will
preserve the const status of the pointer and enforce it by the compiler.

Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Russ Weight <russell.h.weight@intel.com>
Fixes: 23680f0b7d7f ("driver core: make struct class.dev_uevent() take a const *")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2: - respin with changed container_of_const() parameters

 drivers/base/firmware_loader/sysfs.h | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/base/firmware_loader/sysfs.h b/drivers/base/firmware_loader/sysfs.h
index fd0b4ad9bdbb..2060add8ef81 100644
--- a/drivers/base/firmware_loader/sysfs.h
+++ b/drivers/base/firmware_loader/sysfs.h
@@ -80,11 +80,7 @@ struct fw_sysfs {
 	struct firmware *fw;
 	void *fw_upload_priv;
 };
-
-static inline struct fw_sysfs *to_fw_sysfs(const struct device *dev)
-{
-	return container_of(dev, struct fw_sysfs, dev);
-}
+#define to_fw_sysfs(__dev)	container_of_const(__dev, struct fw_sysfs, dev)
 
 void __fw_load_abort(struct fw_priv *fw_priv);
 
-- 
2.38.1


  parent reply	other threads:[~2022-12-05 12:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 12:12 [PATCH v2 1/4] container_of: add container_of_const() that preserves const-ness of the pointer Greg Kroah-Hartman
2022-12-05 12:12 ` [PATCH v2 2/4] device.h: move kobj_to_dev() to use container_of_const() Greg Kroah-Hartman
2022-12-05 14:00   ` Rafael J. Wysocki
2022-12-05 12:12 ` [PATCH v2 3/4] usb.h: take advantage of container_of_const() Greg Kroah-Hartman
2022-12-05 12:12 ` Greg Kroah-Hartman [this message]
2022-12-05 14:23   ` [PATCH v2 4/4] firmware_loader: fix up to_fw_sysfs() to preserve const Rafael J. Wysocki
2022-12-05 13:59 ` [PATCH v2 1/4] container_of: add container_of_const() that preserves const-ness of the pointer Rafael J. Wysocki
2022-12-05 21:24 ` Sakari Ailus
2022-12-06 15:13 ` Matthew Wilcox
2022-12-06 15:54   ` Greg Kroah-Hartman
2022-12-06 17:18     ` Matthew Wilcox
2022-12-06 18:46       ` Greg Kroah-Hartman
2022-12-06 20:18         ` Matthew Wilcox
2022-12-07  8:29           ` Greg Kroah-Hartman
2022-12-07  9:26           ` Rasmus Villemoes
2022-12-07 16:40             ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205121206.166576-4-gregkh@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=jgg@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=rafael@kernel.org \
    --cc=russell.h.weight@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox