From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A605EC4321E for ; Mon, 5 Dec 2022 12:20:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbiLEMUa (ORCPT ); Mon, 5 Dec 2022 07:20:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbiLEMU0 (ORCPT ); Mon, 5 Dec 2022 07:20:26 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD27BF00A for ; Mon, 5 Dec 2022 04:20:25 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id h193so10320083pgc.10 for ; Mon, 05 Dec 2022 04:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Vid55BOGkVKUC6ugttNvlVPCmxI78SYJSflCKm2/2lo=; b=RwOkcT8DY8bHR4l7myzhYvnkTXGwsVR7F7ycfbwnoCpGhcyUpIUst/il59G+OA956Q XbYbBtV0El5ZEcvNcDjDh+6WNkJhq8jQBsRsNK8j9GXqLVUNryt3aI2K28Qw+iofwnz5 gY0BHNZvXX16br9WauSHnjrBqHaW5eo2++yiUfHROwRj3FcHbz2DpU7HQY5u4Qn2ALGX B53ATSPsHv8Ewz/ah8EecL7WNGoIz4cPxCpPoOkHXH89mPwPwmxNJA7hc9f1hzV5DU6m 8aii1lNXLN+m9OzgYk2cQrwXwF0uRUySVcDN06AsZdMzc8VgHZWobS8hbOJg3r4P2e81 VQjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vid55BOGkVKUC6ugttNvlVPCmxI78SYJSflCKm2/2lo=; b=qtK69re/HRdmSiFkA4J5GPEIbVEfQ/ngWFtMvLVy46WqslgZuqCxDuAaktULKRGk4S Fzn4kVT8oqfo8XDeQTKphcUUkvyWsWbafgoDfdzpSoUqBka/eu4qT1YY1FAN9QFQJHuK I96WZ+yOR/zHivxROBstQmABPcDGdzszwI+3sp2L8g8NBxGT3FXClbQTewtdE1Ix/aWz 0cfLPO/vVWpVCXmPJ2fj8ggnUcUSDppevADwwoapuK3fhLB+XXEQLMUvuJLKXwsUIUf+ rPFDh7put23IZIzsTVwAhpvL9GLGkLt55Llc+dbt+fpSwjOCy+D455lJ4MTIKq21JSh4 zuZA== X-Gm-Message-State: ANoB5pnYOLxBSNacucUrL7S3jHYHSpn9QebSQB7fWpwqOzrd5b2LzvbF HYsB2BvUpqxG/olUKjKgwN0p X-Google-Smtp-Source: AA0mqf7fbJzRKUmWsG4BnD+ZT4Whr1kbgIOdUPfXz2ApiKpUMLnQoLrjVr+5P0Fkgu4J9S4iYepfmQ== X-Received: by 2002:a63:5f83:0:b0:478:ab05:4da9 with SMTP id t125-20020a635f83000000b00478ab054da9mr6863980pgb.369.1670242825289; Mon, 05 Dec 2022 04:20:25 -0800 (PST) Received: from thinkpad ([59.92.98.136]) by smtp.gmail.com with ESMTPSA id ca12-20020a17090af30c00b0020bfd6586c6sm9093073pjb.7.2022.12.05.04.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 04:20:24 -0800 (PST) Date: Mon, 5 Dec 2022 17:50:18 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Johan Hovold , Bjorn Andersson , Alim Akhtar , Avri Altman , Andy Gross , Konrad Dybcio , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: ufs: qcom: allow 'dma-coherent' property Message-ID: <20221205122018.GC20192@thinkpad> References: <20221205100837.29212-1-johan+linaro@kernel.org> <20221205100837.29212-2-johan+linaro@kernel.org> <20221205115906.GA20192@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 05, 2022 at 01:07:16PM +0100, Johan Hovold wrote: > On Mon, Dec 05, 2022 at 05:29:06PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Dec 05, 2022 at 11:08:36AM +0100, Johan Hovold wrote: > > > UFS controllers may be cache coherent and must be marked as such in the > > > devicetree to avoid data corruption. > > > > > > This is specifically needed on recent Qualcomm platforms like SC8280XP. > > > > > > Signed-off-by: Johan Hovold > > > --- > > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > > index f2d6298d926c..1f1d286749c0 100644 > > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > > @@ -44,6 +44,8 @@ properties: > > > minItems: 8 > > > maxItems: 11 > > > > > > + dma-coherent: true > > > + > > > > This property is not applicable to all SoCs. So setting true here will make it > > valid for all. > > Yes, it would be a valid, but it will only be added to the DTs of SoCs > that actually require it. No need to re-encode the dtsi in the binding. > But if you make a property valid in the binding then it implies that anyone could add it to DTS which is wrong. You should make this property valid for SoCs that actually support it. Thanks, Mani > Johan -- மணிவண்ணன் சதாசிவம்