From: Jakub Kicinski <kuba@kernel.org>
To: <yang.yang29@zte.com.cn>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<bigeasy@linutronix.de>, <imagedong@tencent.com>,
<kuniyu@amazon.com>, <petrm@nvidia.com>, <liu3101@purdue.edu>,
<wujianguo@chinatelecom.cn>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH linux-next] net: record times of netdev_budget exhausted
Date: Mon, 5 Dec 2022 17:53:14 -0800 [thread overview]
Message-ID: <20221205175314.0487527a@kernel.org> (raw)
In-Reply-To: <202212031612057505056@zte.com.cn>
On Sat, 3 Dec 2022 16:12:05 +0800 (CST) yang.yang29@zte.com.cn wrote:
> A long time ago time_squeeze was used to only record netdev_budget
> exhausted[1]. Then we added netdev_budget_usecs to enable softirq
> tuning[2]. And when polling elapsed netdev_budget_usecs, it's also
> record by time_squeeze.
> For tuning netdev_budget and netdev_budget_usecs respectively, we'd
> better distinguish netdev_budget exhausted from netdev_budget_usecs
> elapsed, so add a new recorder to record netdev_budget exhausted.
You're tuning netdev_budget and netdev_budget_usecs ?
You need to say more because I haven't seen anyone do that before.
time_squeeze is extremely noisy and annoyingly useless,
we need to understand exactly what you're doing before
we accept any changes to this core piece of code.
next prev parent reply other threads:[~2022-12-06 1:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 8:12 [PATCH linux-next] net: record times of netdev_budget exhausted yang.yang29
2022-12-03 10:06 ` kernel test robot
2022-12-03 16:50 ` kernel test robot
2022-12-03 16:50 ` kernel test robot
2022-12-06 1:53 ` Jakub Kicinski [this message]
2022-12-06 2:35 ` yang.yang29
2022-12-06 2:47 ` Jakub Kicinski
2022-12-07 7:27 ` yang.yang29
2022-12-07 7:58 ` Eric Dumazet
2022-12-07 8:17 ` yang.yang29
2022-12-07 23:28 ` Jakub Kicinski
2022-12-07 12:30 ` yang.yang29
2022-12-07 23:32 ` Jakub Kicinski
2022-12-08 1:12 ` yang.yang29
2022-12-08 1:23 ` Jakub Kicinski
2022-12-08 1:42 ` yang.yang29
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205175314.0487527a@kernel.org \
--to=kuba@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liu3101@purdue.edu \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=wujianguo@chinatelecom.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox