* [PATCH linux-next] ipmi/watchdog: use strscpy() to instead of strncpy()
@ 2022-12-05 11:36 yang.yang29
2022-12-05 12:58 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: yang.yang29 @ 2022-12-05 11:36 UTC (permalink / raw)
To: minyard; +Cc: openipmi-developer, linux-kernel, xu.panda, yang.yang29
Xu Panda <xu.panda@zte.com.cn>
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com>
---
drivers/char/ipmi/ipmi_watchdog.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 47365150e431..0d4a8dcacfd4 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -213,8 +213,7 @@ static int set_param_str(const char *val, const struct kernel_param *kp)
char valcp[16];
char *s;
- strncpy(valcp, val, 15);
- valcp[15] = '\0';
+ strscpy(valcp, val, 16);
s = strstrip(valcp);
--
2.15.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] ipmi/watchdog: use strscpy() to instead of strncpy()
2022-12-05 11:36 [PATCH linux-next] ipmi/watchdog: use strscpy() to instead of strncpy() yang.yang29
@ 2022-12-05 12:58 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2022-12-05 12:58 UTC (permalink / raw)
To: yang.yang29; +Cc: openipmi-developer, linux-kernel, xu.panda
On Mon, Dec 05, 2022 at 07:36:40PM +0800, yang.yang29@zte.com.cn wrote:
> Xu Panda <xu.panda@zte.com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
This looks right. Applied, thanks.
-corey
>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
> ---
> drivers/char/ipmi/ipmi_watchdog.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
> index 47365150e431..0d4a8dcacfd4 100644
> --- a/drivers/char/ipmi/ipmi_watchdog.c
> +++ b/drivers/char/ipmi/ipmi_watchdog.c
> @@ -213,8 +213,7 @@ static int set_param_str(const char *val, const struct kernel_param *kp)
> char valcp[16];
> char *s;
>
> - strncpy(valcp, val, 15);
> - valcp[15] = '\0';
> + strscpy(valcp, val, 16);
>
> s = strstrip(valcp);
>
> --
> 2.15.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-05 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-05 11:36 [PATCH linux-next] ipmi/watchdog: use strscpy() to instead of strncpy() yang.yang29
2022-12-05 12:58 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox