Re: [PATCH net-next 1/2] ethtool: update UAPI files

Piergiorgio Beruto
2022-12-04T21:16:13Z

Hello Michal,
I was wondering if you could help me with the issue below.

In short, I'm trying to add a new feature to netlink / ethtool that
requires changes to the UAPI headers. I therefore need to update these
headers in the ethtool userland program as well.

The problem I'm having is that I don't know the procedure for updating
the headers, which is something I need to build my patch to ethtool on.

I understand now this is not a straight copy of the kernel headers to
the ethtool repository.

Should I use some script / procedure / else?
Or should I just post my patch without the headers? (I wonder how we can
verify it though?)

Any help on the matter would be very appreciated.

Kind Regards,
Piergiorgio

On Sun, Dec 04, 2022 at 06:49:45PM +0100, Andrew Lunn wrote:
> On Sun, Dec 04, 2022 at 05:13:22PM +0000, Russell King (Oracle) wrote:
> > On Sun, Dec 04, 2022 at 03:38:37AM +0100, Piergiorgio Beruto wrote:
> >
> > NAK. No description of changes.
>
> Hi Piergiorgio
>
> Look at the previous examples of this:
>
> commit 41fddc0eb01fcd8c5a47b415d3faecd714652513
> Author: Michal Kubecek <mkubecek@suse.cz>
> Date: Mon Jun 13 23:50:26 2022 +0200
>
> update UAPI header copies
>
> Update to kernel v5.18.
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
>
> > > diff --git a/uapi/linux/ethtool.h b/uapi/linux/ethtool.h
> > > index 944711cfa6f6..5f414deacf23 100644
> > > --- a/uapi/linux/ethtool.h
> > > +++ b/uapi/linux/ethtool.h
> > > @@ -11,14 +11,16 @@
> > > * Portions Copyright (C) Sun Microsystems 2008
> > > */
> > >
> > > -#ifndef _LINUX_ETHTOOL_H
> > > -#define _LINUX_ETHTOOL_H
> > > +#ifndef _UAPI_LINUX_ETHTOOL_H
> > > +#define _UAPI_LINUX_ETHTOOL_H
>
> Maybe ask Michal Kubecek how he does this. It does not appear to be a
> straight copy of the headers.
>
> Andrew