From: Christoph Hellwig <hch@lst.de>
To: Aditya Garg <gargaditya08@live.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
"willy@infradead.org" <willy@infradead.org>,
"ira.weiny@intel.com" <ira.weiny@intel.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"songmuchun@bytedance.com" <songmuchun@bytedance.com>,
"slava@dubeyko.com" <slava@dubeyko.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hfsplus: Add module parameter to enable force writes
Date: Tue, 6 Dec 2022 09:52:54 +0100 [thread overview]
Message-ID: <20221206085254.GA9597@lst.de> (raw)
In-Reply-To: <A35CC249-5F77-4B1A-B68F-8E07A38AB73B@live.com>
On Sun, Dec 04, 2022 at 11:01:49AM +0000, Aditya Garg wrote:
> Although, if you think its worth it, the following improvements can be made :-
>
> 1. There is no logging showing that writes have been force enabled. We could add that.
I think this would be very useful.
> 2. We could have separate mount options for journaled and locked volumes (although I dunno in what case we get locked volumes).
We can't really retire the existing option, but if for your use case
you'd prefer to only allow one of them and want to not write to the
other case feel free to submit a patch to add that option.
next prev parent reply other threads:[~2022-12-06 8:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 6:01 [PATCH] hfsplus: Add module parameter to enable force writes Aditya Garg
2022-12-02 20:38 ` Viacheslav Dubeyko
2022-12-02 20:53 ` Andrew Morton
2022-12-02 21:01 ` Matthew Wilcox
2022-12-02 21:10 ` Andrew Morton
2022-12-03 6:22 ` Aditya Garg
2022-12-04 8:07 ` Christoph Hellwig
2022-12-04 11:01 ` Aditya Garg
2022-12-06 8:52 ` Christoph Hellwig [this message]
2022-12-03 7:11 ` [PATCH v2] " Aditya Garg
2022-12-04 1:05 ` kernel test robot
2022-12-04 6:43 ` Aditya Garg
2022-12-06 15:17 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206085254.GA9597@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gargaditya08@live.com \
--cc=ira.weiny@intel.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox