From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BB4C47090 for ; Tue, 6 Dec 2022 08:53:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234340AbiLFIxF (ORCPT ); Tue, 6 Dec 2022 03:53:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234232AbiLFIxB (ORCPT ); Tue, 6 Dec 2022 03:53:01 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 943D1FCFB; Tue, 6 Dec 2022 00:52:59 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 3EBCF68B05; Tue, 6 Dec 2022 09:52:55 +0100 (CET) Date: Tue, 6 Dec 2022 09:52:54 +0100 From: Christoph Hellwig To: Aditya Garg Cc: Christoph Hellwig , Andrew Morton , "willy@infradead.org" , "ira.weiny@intel.com" , "axboe@kernel.dk" , "bvanassche@acm.org" , "keescook@chromium.org" , "songmuchun@bytedance.com" , "slava@dubeyko.com" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] hfsplus: Add module parameter to enable force writes Message-ID: <20221206085254.GA9597@lst.de> References: <53821C76-DAFE-4505-9EC8-BE4ACBEA9DD9@live.com> <20221202125344.4254ab20d2fe0a8e784b33e8@linux-foundation.org> <20221204080752.GA26794@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 04, 2022 at 11:01:49AM +0000, Aditya Garg wrote: > Although, if you think its worth it, the following improvements can be made :- > > 1. There is no logging showing that writes have been force enabled. We could add that. I think this would be very useful. > 2. We could have separate mount options for journaled and locked volumes (although I dunno in what case we get locked volumes). We can't really retire the existing option, but if for your use case you'd prefer to only allow one of them and want to not write to the other case feel free to submit a patch to add that option.